Skip to content

Commit 75bd4b1

Browse files
StefanStojanovicnodejs-github-bot
authored andcommitted
deps: patch V8 to support compilation with MSVC
After enabling -std:c++20 on Windows, patch is now much smaller. PR-URL: nodejs/node#52465 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
1 parent 80d59bf commit 75bd4b1

File tree

2 files changed

+1
-3
lines changed

2 files changed

+1
-3
lines changed

common.gypi

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636

3737
# Reset this number to 0 on major V8 upgrades.
3838
# Increment by one for each non-official patch applied to deps/v8.
39-
'v8_embedder_string': '-node.3',
39+
'v8_embedder_string': '-node.4',
4040

4141
##### V8 defaults for Node.js #####
4242

deps/v8/src/objects/tagged-field.h

-2
Original file line numberDiff line numberDiff line change
@@ -101,12 +101,10 @@ static_assert(sizeof(UnalignedDoubleMember) == sizeof(double));
101101
#define FLEXIBLE_ARRAY_MEMBER(Type, name) \
102102
using FlexibleDataReturnType = Type[0]; \
103103
FlexibleDataReturnType& name() { \
104-
static_assert(alignof(Type) <= alignof(decltype(*this))); \
105104
using ReturnType = Type[0]; \
106105
return reinterpret_cast<ReturnType&>(*(this + 1)); \
107106
} \
108107
const FlexibleDataReturnType& name() const { \
109-
static_assert(alignof(Type) <= alignof(decltype(*this))); \
110108
using ReturnType = Type[0]; \
111109
return reinterpret_cast<const ReturnType&>(*(this + 1)); \
112110
} \

0 commit comments

Comments
 (0)