Skip to content

Commit a12b34e

Browse files
targosnodejs-github-bot
authored andcommitted
deps: silence internal V8 deprecation warning
PR-URL: nodejs/node#52293 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Richard Lau <[email protected]>
1 parent ea8f41a commit a12b34e

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

common.gypi

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636

3737
# Reset this number to 0 on major V8 upgrades.
3838
# Increment by one for each non-official patch applied to deps/v8.
39-
'v8_embedder_string': '-node.4',
39+
'v8_embedder_string': '-node.5',
4040

4141
##### V8 defaults for Node.js #####
4242

deps/v8/src/base/optional.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ namespace base {
1616

1717
// These aliases are deprecated, use std::optional directly.
1818
template <typename T>
19-
using Optional [[deprecated]] = std::optional<T>;
19+
using Optional = std::optional<T>;
2020

2121
using std::in_place;
2222
using std::make_optional;

0 commit comments

Comments
 (0)