Skip to content

Commit 005e343

Browse files
XadillaXaddaleax
authored andcommitted
test: remove require('buffer') from 4 test files
We don't use the global Buffer throughout the lib/ to avoid circular dependency issues in core, but we actually don't need to require it on test files. So remove them on: + test/parallel/test-stream-uint8array.js + test/parallel/test-stream2-finish-pipe.js + test/parallel/test-tls-session-cache.js + test/parallel/test-vm-cached-data.js Refs: #13836 PR-URL: #13844 Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Alexey Orlenko <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
1 parent df3c292 commit 005e343

4 files changed

+0
-4
lines changed

test/parallel/test-stream-uint8array.js

-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
'use strict';
22
const common = require('../common');
33
const assert = require('assert');
4-
const Buffer = require('buffer').Buffer;
54

65
const { Readable, Writable } = require('stream');
76

test/parallel/test-stream2-finish-pipe.js

-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222
'use strict';
2323
require('../common');
2424
const stream = require('stream');
25-
const Buffer = require('buffer').Buffer;
2625

2726
const r = new stream.Readable();
2827
r._read = function(size) {

test/parallel/test-tls-session-cache.js

-1
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@ function doTest(testOptions, callback) {
4646
const fs = require('fs');
4747
const join = require('path').join;
4848
const spawn = require('child_process').spawn;
49-
const Buffer = require('buffer').Buffer;
5049

5150
const keyFile = join(common.fixturesDir, 'agent.key');
5251
const certFile = join(common.fixturesDir, 'agent.crt');

test/parallel/test-vm-cached-data.js

-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ require('../common');
33
const assert = require('assert');
44
const vm = require('vm');
55
const spawnSync = require('child_process').spawnSync;
6-
const Buffer = require('buffer').Buffer;
76

87
function getSource(tag) {
98
return `(function ${tag}() { return '${tag}'; })`;

0 commit comments

Comments
 (0)