Skip to content

Commit 00b0a62

Browse files
MaleDongtargos
MaleDong
authored andcommitted
zlib: remove unused parameters
When `checkRangesOrGetDefault` calls `checkFiniteNumber`, the latter function only has two parameters, so `lower` and `upper` don't need to be passed for validation. PR-URL: #22115 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
1 parent 193a048 commit 00b0a62

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

lib/zlib.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -198,12 +198,12 @@ function checkFiniteNumber(number, name) {
198198
throw err;
199199
}
200200

201-
// 1. Returns def for undefined and NaN
201+
// 1. Returns def for number when it's undefined or NaN
202202
// 2. Returns number for finite numbers >= lower and <= upper
203203
// 3. Throws ERR_INVALID_ARG_TYPE for non-numbers
204204
// 4. Throws ERR_OUT_OF_RANGE for infinite numbers or numbers > upper or < lower
205205
function checkRangesOrGetDefault(number, name, lower, upper, def) {
206-
if (!checkFiniteNumber(number, name, lower, upper)) {
206+
if (!checkFiniteNumber(number, name)) {
207207
return def;
208208
}
209209
if (number < lower || number > upper) {

0 commit comments

Comments
 (0)