Skip to content

Commit 011c5f6

Browse files
Mesteerytargos
authored andcommitted
build: improve readability of texts in workflows
PR-URL: #40988 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent edefb41 commit 011c5f6

File tree

4 files changed

+24
-6
lines changed

4 files changed

+24
-6
lines changed

.github/workflows/authors.yml

+4-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,10 @@ jobs:
2121
GITHUB_TOKEN: ${{ secrets.GH_USER_TOKEN }}
2222
with:
2323
author: Node.js GitHub Bot <[email protected]>
24-
body: "Here are some new additions to the AUTHORS file. This is an automatically generated PR by the `authors.yml` GitHub Action, which runs `tools/update-authors.js`."
24+
body: >
25+
Here are some new additions to the AUTHORS file.
26+
This is an automatically generated PR by the
27+
`authors.yml` GitHub Action, which runs `tools/update-authors.js`.
2528
branch: "actions/authors-update" # Custom branch *just* for this Action.
2629
commit-message: "meta: update AUTHORS"
2730
labels: meta

.github/workflows/close-stalled.yml

+8-2
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,12 @@ on:
33
schedule:
44
- cron: "0 0 * * *"
55

6+
env:
7+
CLOSE_MESSAGE: >
8+
Closing this because it has stalled. Feel free to reopen if this issue/PR
9+
is still relevant, or to ping the collaborator who labelled it stalled if
10+
you have any questions.
11+
612
jobs:
713
stale:
814
if: github.repository == 'nodejs/node'
@@ -14,8 +20,8 @@ jobs:
1420
days-before-close: 30
1521
stale-pr-label: stalled
1622
stale-issue-label: stalled
17-
close-issue-message: Closing this because it has stalled. Feel free to reopen if this issue is still relevant, or to ping the collaborator who labelled it stalled if you have any questions.
18-
close-pr-message: Closing this because it has stalled. Feel free to reopen if this PR is still relevant, or to ping the collaborator who labelled it stalled if you have any questions.
23+
close-issue-message: ${{ env.CLOSE_MESSAGE }}
24+
close-pr-message: ${{ env.CLOSE_MESSAGE }}
1925
# used to filter issues to check whether or not should be closed, avoids hitting maximum operations allowed if needing to paginate through all open issues
2026
only-labels: stalled
2127
# max requests it will send per run to the GitHub API before it deliberately exits to avoid hitting API rate limits

.github/workflows/comment-labeled.yml

+8-2
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,12 @@ on:
55
pull_request_target:
66
types: [labeled]
77

8+
env:
9+
STALE_MESSAGE: >
10+
This issue/PR was marked as stalled, it will be automatically closed in 30 days.
11+
If it should remain open, please leave a comment explaining why it should remain open.
12+
FAST_TRACK_MESSAGE: Fast-track has been requested by @${{ github.actor }}. Please 👍 to approve.
13+
814
jobs:
915
staleComment:
1016
if: github.repository == 'nodejs/node' && github.event.label.name == 'stalled'
@@ -14,7 +20,7 @@ jobs:
1420
env:
1521
NUMBER: ${{ github.event.issue.number || github.event.pull_request.number }}
1622
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
17-
run: gh issue comment "$NUMBER" --repo ${{ github.repository }} --body "This issue/PR was marked as stalled, it will be automatically closed in 30 days. If it should remain open, please leave a comment explaining why it should remain open."
23+
run: gh issue comment "$NUMBER" --repo ${{ github.repository }} --body "$STALE_MESSAGE"
1824

1925
fastTrack:
2026
if: github.repository == 'nodejs/node' && github.event_name == 'pull_request_target' && github.event.label.name == 'fast-track'
@@ -23,4 +29,4 @@ jobs:
2329
- name: Request Fast-Track
2430
env:
2531
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
26-
run: gh pr comment ${{ github.event.pull_request.number }} --repo ${{ github.repository }} --body "Fast-track has been requested by @${{ github.actor }}. Please 👍 to approve."
32+
run: gh pr comment ${{ github.event.pull_request.number }} --repo ${{ github.repository }} --body "$FAST_TRACK_MESSAGE"

.github/workflows/license-builder.yml

+4-1
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,9 @@ jobs:
2222
author: Node.js GitHub Bot <[email protected]>
2323
branch: actions/license-builder
2424
title: "doc: run license-builder"
25-
body: "License is likely out of date. This is an automatically generated PR by the `license-builder.yml` GitHub Action, which runs `license-builder.sh` and submits a new PR or updates an existing PR."
25+
body: >
26+
License is likely out of date. This is an automatically generated PR by
27+
the `license-builder.yml` GitHub Action, which runs `license-builder.sh`
28+
and submits a new PR or updates an existing PR.
2629
commit-message: 'doc: run license-builder'
2730
labels: meta

0 commit comments

Comments
 (0)