Skip to content

Commit 015671d

Browse files
mmarchinitargos
authored andcommitted
deps: V8: cherry-pick b38dfaf3a633
Original commit message: [postmortem] update Symbol and *String metadata Symbol and *String classes are now declared on Torque with generateCppClass, which means they don't use macro accessors anymore. As such, the gen-postmortem-metadata script is not able to automatically detect fields for those classes. Define metadata for those fields manually for now. In the future we might want to generate it from Torque for consistency. Also renamed a few *String fields metadata to match the expected format (className__fieldName__fieldType). For more context: nodejs/llnode#287 (comment). [email protected], [email protected], [email protected], [email protected] Change-Id: I82fe8315cdbfd1b8c64c6a8d5dc011b1edaec39e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1847783 Reviewed-by: Toon Verwaest <[email protected]> Commit-Queue: Toon Verwaest <[email protected]> Cr-Commit-Position: refs/heads/master@{#64313} Refs: v8/v8@b38dfaf PR-URL: #30870 Reviewed-By: Michael Dawson <[email protected]>
1 parent 8c5e951 commit 015671d

File tree

2 files changed

+6
-10
lines changed

2 files changed

+6
-10
lines changed

common.gypi

+1-1
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838

3939
# Reset this number to 0 on major V8 upgrades.
4040
# Increment by one for each non-official patch applied to deps/v8.
41-
'v8_embedder_string': '-node.28',
41+
'v8_embedder_string': '-node.29',
4242

4343
##### V8 defaults for Node.js #####
4444

deps/v8/tools/gen-postmortem-metadata.py

+5-9
Original file line numberDiff line numberDiff line change
@@ -230,15 +230,6 @@
230230

231231
{ 'name': 'class_SharedFunctionInfo__function_data__Object',
232232
'value': 'SharedFunctionInfo::kFunctionDataOffset' },
233-
234-
{ 'name': 'class_ConsString__first_offset__int',
235-
'value': 'ConsString::kFirstOffset' },
236-
{ 'name': 'class_ConsString__second_offset__int',
237-
'value': 'ConsString::kSecondOffset' },
238-
{ 'name': 'class_SlicedString__offset_offset__int',
239-
'value': 'SlicedString::kOffsetOffset' },
240-
{ 'name': 'class_ThinString__actual_offset__int',
241-
'value': 'ThinString::kActualOffset' },
242233
];
243234

244235
#
@@ -287,6 +278,11 @@
287278
'Code, instruction_size, int, kInstructionSizeOffset',
288279
'String, length, int32_t, kLengthOffset',
289280
'DescriptorArray, header_size, uintptr_t, kHeaderSize',
281+
'ConsString, first, String, kFirstOffset',
282+
'ConsString, second, String, kSecondOffset',
283+
'SlicedString, offset, SMI, kOffsetOffset',
284+
'ThinString, actual, String, kActualOffset',
285+
'Symbol, name, Object, kNameOffset',
290286
];
291287

292288
#

0 commit comments

Comments
 (0)