Skip to content

Commit 01b112a

Browse files
cjihrigtargos
authored andcommitted
test: update postmortem metadata test for V8 7.3
The V8 7.3 update requires the following adjustments to the postmortem debugging metadata constants: - v8dbg_prop_idx_first was removed in v8/v8@1ad0cd5 - v8dbg_jsarray_buffer_was_neutered_mask was renamed to v8dbg_jsarray_buffer_was_detached_mask in v8/v8@f68ee6e - v8dbg_jsarray_buffer_was_neutered_shift was renamed to v8dbg_jsarray_buffer_was_detached_shift in v8/v8@f68ee6e - v8dbg_class_Map__instance_descriptors__DescriptorArray moved to v8dbg_class_Map__raw_instance_descriptors__DescriptorArray and began using ACCESSORS2 in v8/v8@799dfad The following postmortem debugging constants were also impacted by V8's introduction of ACCESSORS2, but do not need to be updated the test: - v8dbg_class_ThinString__actual__String changed in v8/v8@0f581e4 - v8dbg_class_UncompiledData__inferred_name__String changed in v8/v8@0f581e4 - v8dbg_class_JSFunction__shared__SharedFunctionInfo changed in v8/v8@8162090 - v8dbg_class_SharedFunctionInfo__function_data__Object had its accessor removed in v8/v8@a55803a This has been fixed in gen-postmortem-metadata.py. PR-URL: #25852 Reviewed-By: Ujjwal Sharma <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Ali Ijaz Sheikh <[email protected]>
1 parent 38ad285 commit 01b112a

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

test/v8-updates/test-postmortem-metadata.js

+3-4
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ function getExpectedSymbols() {
8484
'v8dbg_class_Map__constructor_or_backpointer__Object',
8585
'v8dbg_class_Map__inobject_properties_start_or_constructor_function_index__char',
8686
'v8dbg_class_Map__instance_type__uint16_t',
87-
'v8dbg_class_Map__instance_descriptors__DescriptorArray',
87+
'v8dbg_class_Map__raw_instance_descriptors__DescriptorArray',
8888
'v8dbg_class_Map__instance_size_in_words__char',
8989
'v8dbg_class_Oddball__kind_offset__int',
9090
'v8dbg_class_Script__line_ends__Object',
@@ -116,8 +116,8 @@ function getExpectedSymbols() {
116116
'v8dbg_frametype_InternalFrame',
117117
'v8dbg_frametype_OptimizedFrame',
118118
'v8dbg_frametype_StubFrame',
119-
'v8dbg_jsarray_buffer_was_neutered_mask',
120-
'v8dbg_jsarray_buffer_was_neutered_shift',
119+
'v8dbg_jsarray_buffer_was_detached_mask',
120+
'v8dbg_jsarray_buffer_was_detached_shift',
121121
'v8dbg_namedictionary_prefix_start_index',
122122
'v8dbg_namedictionaryshape_entry_size',
123123
'v8dbg_namedictionaryshape_prefix_size',
@@ -134,7 +134,6 @@ function getExpectedSymbols() {
134134
'v8dbg_prop_desc_key',
135135
'v8dbg_prop_desc_size',
136136
'v8dbg_prop_desc_value',
137-
'v8dbg_prop_idx_first',
138137
'v8dbg_prop_index_mask',
139138
'v8dbg_prop_index_shift',
140139
'v8dbg_prop_kind_mask',

0 commit comments

Comments
 (0)