Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit 01d8b91

Browse files
danbevcodebytere
authored andcommittedJun 18, 2020
tools: prevent js2c from running if nothing changed
This commit updates tools/js2c.py to touch the target output file , <(SHARED_INTERMEDIATE_DIR)/node_javascript.cc, even if the content has not changed. This is to "help" the build system so that it can compare the inputs against the output to determine if the gyp action should be run. I believe the issue here is that if js2c.py is updated this can cause the action to be run as the node_javascript.cc target would be older than js2c.py. But when the target is run the timestamp for node_javascript.cc will not be updated (because we have not changed anything that would change the contents of the file) so the js2c.py prerequisite will always be passed and the target always run. Using the update in this commit one would have to touch/modify one of the js files specified in the library_files list, config.gypi, or tools/js2c.py for this action to be run again. PR-URL: #33844 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
1 parent e837f00 commit 01d8b91

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed
 

‎tools/js2c.py

+1
Original file line numberDiff line numberDiff line change
@@ -178,6 +178,7 @@ def write_if_chaged(content, target):
178178
else:
179179
old_content = ''
180180
if old_content == content:
181+
os.utime(target, None)
181182
return
182183
with open(target, "wt") as output:
183184
output.write(content)

0 commit comments

Comments
 (0)
Please sign in to comment.