Skip to content

Commit 020057a

Browse files
committedAug 16, 2018
build: make lint-ci work properly on Linux make
PR-URL: #19746 Reviewed-By: Joyee Cheung <[email protected]>
1 parent 4f3bf04 commit 020057a

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed
 

‎Makefile

+3-2
Original file line numberDiff line numberDiff line change
@@ -1072,7 +1072,8 @@ lint-js-ci:
10721072
jslint-ci: lint-js-ci
10731073
@echo "Please use lint-js-ci instead of jslint-ci"
10741074

1075-
LINT_CPP_ADDON_DOC_FILES = $(wildcard test/addons/??_*/*.cc test/addons/??_*/*.h)
1075+
LINT_CPP_ADDON_DOC_FILES_GLOB = test/addons/??_*/*.cc test/addons/??_*/*.h
1076+
LINT_CPP_ADDON_DOC_FILES = $(wildcard $(LINT_CPP_ADDON_DOC_FILES_GLOB))
10761077
LINT_CPP_EXCLUDE ?=
10771078
LINT_CPP_EXCLUDE += src/node_root_certs.h
10781079
LINT_CPP_EXCLUDE += $(LINT_CPP_ADDON_DOC_FILES)
@@ -1113,7 +1114,7 @@ tools/.cpplintstamp: $(LINT_CPP_FILES)
11131114

11141115
lint-addon-docs: test/addons/.docbuildstamp
11151116
@echo "Running C++ linter on addon docs..."
1116-
@$(PYTHON) tools/cpplint.py --filter=$(ADDON_DOC_LINT_FLAGS) $(LINT_CPP_ADDON_DOC_FILES)
1117+
@$(PYTHON) tools/cpplint.py --filter=$(ADDON_DOC_LINT_FLAGS) $(LINT_CPP_ADDON_DOC_FILES_GLOB)
11171118

11181119
cpplint: lint-cpp
11191120
@echo "Please use lint-cpp instead of cpplint"

0 commit comments

Comments
 (0)
Please sign in to comment.