Skip to content

Commit 0217194

Browse files
addaleaxrefack
authored andcommitted
deps: V8: cherry-pick 5b0510d
Original commit message: Give the implementation of v8::MicrotaskQueue::New This adds the entrypoint to MicrotaskQueue, which used to miss the implementation. Bug: v8:8124 Change-Id: I114fb69d975ee75c86b19349ca76789e425ea910 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1505232 Reviewed-by: Yang Guo <[email protected]> Commit-Queue: Taiju Tsuiki <[email protected]> Cr-Commit-Position: refs/heads/master@{#60076} Refs: v8/v8@5b0510d PR-URL: #26685 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
1 parent bf572c7 commit 0217194

File tree

3 files changed

+7
-2
lines changed

3 files changed

+7
-2
lines changed

common.gypi

+1-1
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737

3838
# Reset this number to 0 on major V8 upgrades.
3939
# Increment by one for each non-official patch applied to deps/v8.
40-
'v8_embedder_string': '-node.3',
40+
'v8_embedder_string': '-node.4',
4141

4242
##### V8 defaults for Node.js #####
4343

deps/v8/include/v8.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -6779,7 +6779,7 @@ class V8_EXPORT MicrotaskQueue {
67796779
/**
67806780
* Creates an empty MicrotaskQueue instance.
67816781
*/
6782-
static std::unique_ptr<MicrotaskQueue> New();
6782+
static std::unique_ptr<MicrotaskQueue> New(Isolate* isolate);
67836783

67846784
virtual ~MicrotaskQueue() = default;
67856785

deps/v8/src/api.cc

+5
Original file line numberDiff line numberDiff line change
@@ -8931,6 +8931,11 @@ void v8::Isolate::LocaleConfigurationChangeNotification() {
89318931
#endif // V8_INTL_SUPPORT
89328932
}
89338933

8934+
// static
8935+
std::unique_ptr<MicrotaskQueue> MicrotaskQueue::New(Isolate* isolate) {
8936+
return i::MicrotaskQueue::New(reinterpret_cast<i::Isolate*>(isolate));
8937+
}
8938+
89348939
MicrotasksScope::MicrotasksScope(Isolate* isolate, MicrotasksScope::Type type)
89358940
: MicrotasksScope(
89368941
isolate,

0 commit comments

Comments
 (0)