Skip to content

Commit 02a87b0

Browse files
Trotttargos
authored andcommitted
doc: update markdown formatting for *.md files
Fix formatting that will change when run through upcoming remark preset. PR-URL: #40154 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
1 parent f7c8274 commit 02a87b0

File tree

5 files changed

+72
-40
lines changed

5 files changed

+72
-40
lines changed

BUILDING.md

+44-25
Original file line numberDiff line numberDiff line change
@@ -120,31 +120,31 @@ platforms. This is true regardless of entries in the table below.
120120
| FreeBSD | x64 | >= 11 | Experimental | Downgraded as of Node.js 12 <sup>[7](#fn7)</sup> |
121121

122122
<em id="fn1">1</em>: GCC 8 is not provided on the base platform. Users will
123-
need the
124-
[Toolchain test builds PPA](https://launchpad.net/~ubuntu-toolchain-r/+archive/ubuntu/test?field.series_filter=xenial)
125-
or similar to source a newer compiler.
123+
need the
124+
[Toolchain test builds PPA](https://launchpad.net/~ubuntu-toolchain-r/+archive/ubuntu/test?field.series_filter=xenial)
125+
or similar to source a newer compiler.
126126

127127
<em id="fn2">2</em>: GCC 8 is not provided on the base platform. Users will
128-
need the
129-
[devtoolset-8](https://www.softwarecollections.org/en/scls/rhscl/devtoolset-8/)
130-
or later to source a newer compiler.
128+
need the
129+
[devtoolset-8](https://www.softwarecollections.org/en/scls/rhscl/devtoolset-8/)
130+
or later to source a newer compiler.
131131

132132
<em id="fn3">3</em>: Older kernel versions may work for ARM64. However the
133-
Node.js test infrastructure only tests >= 4.5.
133+
Node.js test infrastructure only tests >= 4.5.
134134

135135
<em id="fn4">4</em>: On Windows, running Node.js in Windows terminal emulators
136-
like `mintty` requires the usage of [winpty](https://github.com/rprichard/winpty)
137-
for the tty channels to work (e.g. `winpty node.exe script.js`).
138-
In "Git bash" if you call the node shell alias (`node` without the `.exe`
139-
extension), `winpty` is used automatically.
136+
like `mintty` requires the usage of [winpty](https://github.com/rprichard/winpty)
137+
for the tty channels to work (e.g. `winpty node.exe script.js`).
138+
In "Git bash" if you call the node shell alias (`node` without the `.exe`
139+
extension), `winpty` is used automatically.
140140

141141
<em id="fn5">5</em>: The Windows Subsystem for Linux (WSL) is not
142-
supported, but the GNU/Linux build process and binaries should work. The
143-
community will only address issues that reproduce on native GNU/Linux
144-
systems. Issues that only reproduce on WSL should be reported in the
145-
[WSL issue tracker](https://github.com/Microsoft/WSL/issues). Running the
146-
Windows binary (`node.exe`) in WSL is not recommended. It will not work
147-
without workarounds such as stdio redirection.
142+
supported, but the GNU/Linux build process and binaries should work. The
143+
community will only address issues that reproduce on native GNU/Linux
144+
systems. Issues that only reproduce on WSL should be reported in the
145+
[WSL issue tracker](https://github.com/Microsoft/WSL/issues). Running the
146+
Windows binary (`node.exe`) in WSL is not recommended. It will not work
147+
without workarounds such as stdio redirection.
148148

149149
<em id="fn6">6</em>: Running Node.js on x86 Windows should work and binaries
150150
are provided. However, tests in our infrastructure only run on WoW64.
@@ -195,7 +195,7 @@ Ubuntu 14.04 and Debian 8.
195195
#### OpenSSL asm support
196196

197197
OpenSSL-1.1.1 requires the following assembler version for use of asm
198-
support on x86_64 and ia32.
198+
support on x86\_64 and ia32.
199199

200200
For use of AVX-512,
201201

@@ -212,9 +212,9 @@ For use of AVX2,
212212
* nasm version 2.10 or higher in Windows
213213

214214
Please refer to
215-
<https://www.openssl.org/docs/man1.1.1/man3/OPENSSL_ia32cap.html> for details.
215+
<https://www.openssl.org/docs/man1.1.1/man3/OPENSSL_ia32cap.html> for details.
216216

217-
If compiling without one of the above, use `configure` with the
217+
If compiling without one of the above, use `configure` with the
218218
`--openssl-no-asm` flag. Otherwise, `configure` will fail.
219219

220220
### Previous versions of this document
@@ -232,6 +232,7 @@ Consult previous versions of this document for older versions of Node.js:
232232
### Note about Python
233233

234234
The Node.js project supports Python >= 3 for building and testing.
235+
235236
### Unix and macOS
236237

237238
#### Unix prerequisites
@@ -480,7 +481,7 @@ release version is actually installed when you run `make install`.
480481
To use the debug build with all the normal dependencies overwrite the release
481482
version in the install directory:
482483

483-
``` console
484+
```console
484485
$ make install PREFIX=/opt/node-debug/
485486
$ cp -a -f out/Debug/node /opt/node-debug/node
486487
```
@@ -496,7 +497,7 @@ was captured on (i.e. 64-bit `gdb` for `node` built on a 64-bit system, Linux
496497

497498
Example of generating a backtrace from the core dump:
498499

499-
``` console
500+
```console
500501
$ gdb /opt/node-debug/node core.node.8.1535359906
501502
$ backtrace
502503
```
@@ -507,12 +508,12 @@ $ backtrace
507508
related bugs. ASAN builds are currently only supported on linux.
508509
If you want to check it on Windows or macOS or you want a consistent toolchain
509510
on Linux, you can try [Docker](https://www.docker.com/products/docker-desktop)
510-
(using an image like `gengjiawen/node-build:2020-02-14`).
511+
(using an image like `gengjiawen/node-build:2020-02-14`).
511512

512513
The `--debug` is not necessary and will slow down build and testing, but it can
513514
show clear stacktrace if ASAN hits an issue.
514515

515-
``` console
516+
```console
516517
$ ./configure --debug --enable-asan && make -j4
517518
$ make test-only
518519
```
@@ -521,20 +522,24 @@ $ make test-only
521522

522523
If you plan to frequently rebuild Node.js, especially if using several branches,
523524
installing `ccache` can help to greatly reduce build times. Set up with:
525+
524526
```console
525527
$ sudo apt install ccache # for Debian/Ubuntu, included in most Linux distros
526528
$ ccache -o cache_dir=<tmp_dir>
527529
$ ccache -o max_size=5.0G
528530
$ export CC="ccache gcc" # add to your .profile
529531
$ export CXX="ccache g++" # add to your .profile
530532
```
533+
531534
This will allow for near-instantaneous rebuilds even when switching branches.
532535

533536
When modifying only the JS layer in `lib`, it is possible to externally load it
534537
without modifying the executable:
538+
535539
```console
536540
$ ./configure --node-builtin-modules-path $(pwd)
537541
```
542+
538543
The resulting binary won't include any JS files and will try to load them from
539544
the specified directory. The JS debugger of Visual Studio Code supports this
540545
configuration since the November 2020 version and allows for setting
@@ -678,7 +683,7 @@ $ ./configure --with-intl=full-icu
678683

679684
### Trimmed: `small-icu` (English only) support
680685

681-
In this configuration, only English data is included, but
686+
In this configuration, only English data is included, but
682687
the full `Intl` (ECMA-402) APIs. It does not need to download
683688
any dependencies to function. You can add full data at runtime.
684689

@@ -774,6 +779,7 @@ If you want to build Node.js using openssl-3.0.0+quic, you can follow these
774779
steps:
775780

776781
**clone OpenSSL source and prepare build**
782+
777783
```bash
778784
git clone [email protected]:quictls/openssl.git
779785

@@ -791,6 +797,7 @@ will publish the OpenSSL libraries and such. We will also use this path
791797
(and sub-paths) later when compiling Node.js.
792798

793799
**compile and install OpenSSL**
800+
794801
```console
795802
make -j8
796803
make install
@@ -806,6 +813,7 @@ find the `fipsmodule.cnf` file - let's add the following to the end of the
806813
`openssl.cnf` file.
807814

808815
**alter openssl.cnf**
816+
809817
```text
810818
.include fipsmodule.cnf
811819
@@ -826,6 +834,7 @@ sure that you specify an absolute path for the `.include fipsmodule.cnf` line -
826834
using relative paths did not work on my system!
827835

828836
**alter openssl.cnf using a script**
837+
829838
```console
830839
cat <<EOT >> /path/to/install/dir/ssl/openssl.cnf
831840
.include /path/to/install/dir/ssl/fipsmodule.cnf
@@ -845,12 +854,14 @@ EOT
845854
As you might have picked a non-custom path for your OpenSSL install dir, we
846855
have to export the following two environment variables in order for Node.js to
847856
find our OpenSSL modules we built beforehand:
857+
848858
```console
849859
export OPENSSL_CONF=/path/to/install/dir/ssl/openssl.cnf
850860
export OPENSSL_MODULES=/path/to/install/dir/lib/ossl-modules
851861
```
852862

853863
**build Node.js**
864+
854865
```console
855866
./configure \
856867
--shared-openssl \
@@ -865,6 +876,7 @@ make -j8
865876
```
866877

867878
**verify the produced executable**
879+
868880
```console
869881
ldd ./node
870882
linux-vdso.so.1 (0x00007ffd7917b000)
@@ -884,12 +896,14 @@ If the `ldd` command says that `libcrypto` cannot be found one needs to set
884896
`--shared-openssl-libpath` (see previous step).
885897

886898
**verify the OpenSSL version**
899+
887900
```console
888901
./node -p process.versions.openssl
889902
3.0.0-alpha16+quic
890903
```
891904

892905
**verify that FIPS is available**
906+
893907
```console
894908
./node -p 'process.config.variables.openssl_is_fips'
895909
true
@@ -905,13 +919,16 @@ executable. See sections
905919
[Enabling FIPS using OpenSSL config](#enabling-fips-using-openssl-config) below.
906920

907921
### Enabling FIPS using Node.js options
922+
908923
This is done using one of the Node.js options `--enable-fips` or
909924
`--force-fips`, for example:
925+
910926
```console
911927
$ node --enable-fips -p 'crypto.getFips()'
912928
```
913929

914930
### Enabling FIPS using OpenSSL config
931+
915932
This example show that using OpenSSL's configuration file, FIPS can be enabled
916933
without specifying the `--enable-fips` or `--force-fips` options by setting
917934
`default_properties = fips=yes` in the FIPS configuration file. See
@@ -920,6 +937,7 @@ for details.
920937

921938
For this to work the OpenSSL configuration file (default openssl.cnf) needs to
922939
be updated. The following shows an example:
940+
923941
```console
924942
openssl_conf = openssl_init
925943

@@ -939,6 +957,7 @@ activate = 1
939957
[algorithm_sect]
940958
default_properties = fips=yes
941959
```
960+
942961
After this change Node.js can be run without the `--enable-fips` or `--force-fips`
943962
options.
944963

CHANGELOG.md

+5-3
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ Please use the following table to find the changelog for a specific Node.js
2424
release.
2525

2626
<!--lint disable maximum-line-length-->
27+
2728
<table>
2829
<tr>
2930
<th title="Current"><a href="doc/changelogs/CHANGELOG_V16.md">16</a><sup>Current</sup></th>
@@ -131,8 +132,9 @@ release.
131132
LTS releases.
132133
* Release versions in **bold** text are the most recent supported releases.
133134

134-
----
135-
----
135+
***
136+
137+
***
136138

137139
## 2016-05-06, Version 0.12.14 (Maintenance), @rvagg
138140

@@ -1348,7 +1350,7 @@ release.
13481350

13491351
## 2009.08.21, Version 0.1.5
13501352

1351-
<a href="doc/changelogs/CHANGELOG_ARCHIVE.md#0.1.5>Moved to doc/changelogs/CHANGELOG_V6.md#6.0.0</a>.
1353+
<a href="doc/changelogs/CHANGELOG_ARCHIVE.md#0.1.5">Moved to doc/changelogs/CHANGELOG_V6.md#6.0.0</a>.
13521354

13531355
## 2009.08.13, Version 0.1.4
13541356

CONTRIBUTING.md

+3
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,10 @@ See [details on our policy on Code of Conduct](./doc/guides/contributing/code-of
2929
* [Notes](./doc/guides/contributing/pull-requests.md#notes)
3030

3131
<a id="developers-certificate-of-origin"></a>
32+
3233
## Developer's Certificate of Origin 1.1
3334

35+
<pre>
3436
By making a contribution to this project, I certify that:
3537

3638
(a) The contribution was created in whole or in part by me and I
@@ -54,3 +56,4 @@ By making a contribution to this project, I certify that:
5456
personal information I submit with it, including my sign-off) is
5557
maintained indefinitely and may be redistributed consistent with
5658
this project or the open source license(s) involved.
59+
</pre>

GOVERNANCE.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -153,8 +153,8 @@ the nomination fails.
153153

154154
There are steps a nominator can take in advance to make a nomination as
155155
frictionless as possible. To request feedback from other collaborators in
156-
private, use the [collaborators discussion page][]
157-
(which only collaborators may view). A nominator may also work with the
156+
private, use the [collaborators discussion page][]
157+
(which only collaborators may view). A nominator may also work with the
158158
nominee to improve their contribution profile.
159159

160160
Collaborators might overlook someone with valuable contributions. In that case,

onboarding.md

+18-10
Original file line numberDiff line numberDiff line change
@@ -51,12 +51,13 @@ onboarding session.
5151
[Publicizing or hiding organization membership][].
5252

5353
* Notifications:
54-
* Use [https://github.com/notifications](https://github.com/notifications) or
54+
* Use <https://github.com/notifications> or
5555
set up email
5656
* Watching the main repository will flood your inbox (several hundred
5757
notifications on typical weekdays), so be prepared
5858

5959
The project has two venues for real-time discussion:
60+
6061
* [`#nodejs-dev`](https://openjs-foundation.slack.com/archives/C019Y2T6STH) on
6162
the [OpenJS Foundation](https://slack-invite.openjsf.org/)
6263

@@ -71,7 +72,7 @@ The project has two venues for real-time discussion:
7172
* The best outcome is for people who come to our issue tracker to feel like
7273
they can come back again.
7374

74-
* You are expected to follow *and* hold others accountable to the
75+
* You are expected to follow _and_ hold others accountable to the
7576
[Code of Conduct][].
7677

7778
## Managing the issue tracker
@@ -88,7 +89,7 @@ The project has two venues for real-time discussion:
8889
not perfect, of course. Feel free to apply relevant labels and remove
8990
irrelevant labels from pull requests and issues.
9091
* `semver-{minor,major}`:
91-
* If a change has the remote *chance* of breaking something, use the
92+
* If a change has the remote _chance_ of breaking something, use the
9293
`semver-major` label
9394
* When adding a `semver-*` label, add a comment explaining why you're adding
9495
it. Do it right away so you don't forget!
@@ -113,27 +114,34 @@ The project has two venues for real-time discussion:
113114
## Reviewing pull requests
114115

115116
* The primary goal is for the codebase to improve.
117+
116118
* Secondary (but not far off) is for the person submitting code to succeed. A
117119
pull request from a new contributor is an opportunity to grow the community.
120+
118121
* Review a bit at a time. Do not overwhelm new contributors.
119122
* It is tempting to micro-optimize. Don't succumb to that temptation. We
120123
change V8 often. Techniques that provide improved performance today may be
121124
unnecessary in the future.
125+
122126
* Be aware: Your opinion carries a lot of weight!
127+
123128
* Nits (requests for small changes that are not essential) are fine, but try to
124129
avoid stalling the pull request.
125130
* Identify them as nits when you comment: `Nit: change foo() to bar().`
126131
* If they are stalling the pull request, fix them yourself on merge.
132+
127133
* Insofar as possible, issues should be identified by tools rather than human
128134
reviewers. If you are leaving comments about issues that could be identified
129135
by tools but are not, consider implementing the necessary tooling.
136+
130137
* Minimum wait for comments time
131138
* There is a minimum waiting time which we try to respect for non-trivial
132139
changes so that people who may have important input in such a distributed
133140
project are able to respond.
134141
* For non-trivial changes, leave the pull request open for at least 48 hours.
135142
* If a pull request is abandoned, check if they'd mind if you took it over
136143
(especially if it just has nits left).
144+
137145
* Approving a change
138146
* Collaborators indicate that they have reviewed and approve of the changes in
139147
a pull request using GitHub’s approval interface
@@ -159,7 +167,7 @@ The project has two venues for real-time discussion:
159167
such as `async_hooks`.
160168

161169
* Continuous Integration (CI) Testing:
162-
* [https://ci.nodejs.org/](https://ci.nodejs.org/)
170+
* <https://ci.nodejs.org/>
163171
* It is not automatically run. You need to start it manually.
164172
* Log in on CI is integrated with GitHub. Try to log in now!
165173
* You will be using `node-test-pull-request` most of the time. Go there now!
@@ -228,12 +236,12 @@ needs to be pointed out separately during the onboarding.
228236
* Almost any mistake you could make can be fixed or reverted.
229237
* The existing collaborators trust you and are grateful for your help!
230238
* Other repositories:
231-
* [https://github.com/nodejs/TSC](https://github.com/nodejs/TSC)
232-
* [https://github.com/nodejs/build](https://github.com/nodejs/build)
233-
* [https://github.com/nodejs/nodejs.org](https://github.com/nodejs/nodejs.org)
234-
* [https://github.com/nodejs/readable-stream](https://github.com/nodejs/readable-stream)
235-
* [https://github.com/nodejs/LTS](https://github.com/nodejs/LTS)
236-
* [https://github.com/nodejs/citgm](https://github.com/nodejs/citgm)
239+
* <https://github.com/nodejs/TSC>
240+
* <https://github.com/nodejs/build>
241+
* <https://github.com/nodejs/nodejs.org>
242+
* <https://github.com/nodejs/readable-stream>
243+
* <https://github.com/nodejs/LTS>
244+
* <https://github.com/nodejs/citgm>
237245
* The OpenJS Foundation hosts regular summits for active contributors to the
238246
Node.js project, where we have face-to-face discussions about our work on the
239247
project. The Foundation has travel funds to cover participants' expenses

0 commit comments

Comments
 (0)