Skip to content

Commit 035a24e

Browse files
joyeecheungMylesBorins
authored andcommittedDec 11, 2017
build: enforce order of dependency when building addons
PR-URL: #17048 Fixes: #17043 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
1 parent 2f34d35 commit 035a24e

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed
 

‎Makefile

+2-2
Original file line numberDiff line numberDiff line change
@@ -314,7 +314,7 @@ test/addons/.buildstamp: config.gypi \
314314
# .buildstamp is out of date and need a rebuild.
315315
# Just goes to show that recursive make really is harmful...
316316
# TODO(bnoordhuis) Force rebuild after gyp update.
317-
build-addons: $(NODE_EXE) test/addons/.buildstamp
317+
build-addons: | $(NODE_EXE) test/addons/.buildstamp
318318

319319
ADDONS_NAPI_BINDING_GYPS := \
320320
$(filter-out test/addons-napi/??_*/binding.gyp, \
@@ -353,7 +353,7 @@ test/addons-napi/.buildstamp: config.gypi \
353353
# .buildstamp is out of date and need a rebuild.
354354
# Just goes to show that recursive make really is harmful...
355355
# TODO(bnoordhuis) Force rebuild after gyp or node-gyp update.
356-
build-addons-napi: $(NODE_EXE) test/addons-napi/.buildstamp
356+
build-addons-napi: | $(NODE_EXE) test/addons-napi/.buildstamp
357357

358358
clear-stalled:
359359
# Clean up any leftover processes but don't error if found.

0 commit comments

Comments
 (0)
Please sign in to comment.