Skip to content

Commit 03827dd

Browse files
committed
build: allow Python 3.8
PR-URL: #30194 Reviewed-By: Christian Clauss <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
1 parent cc1cd2b commit 03827dd

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

BUILDING.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -246,7 +246,7 @@ transition before the year-end deadline.
246246
* GNU Make 3.81 or newer
247247
* Python (see note above)
248248
* Python 2.7
249-
* Python 3.5, 3.6, and 3.7 are experimental.
249+
* Python 3.5, 3.6, 3.7, and 3.8 are experimental.
250250

251251
Installation via Linux package manager can be achieved with:
252252

@@ -262,7 +262,7 @@ FreeBSD and OpenBSD users may also need to install `libexecinfo`.
262262
* Xcode Command Line Tools >= 10 for macOS
263263
* Python (see note above)
264264
* Python 2.7
265-
* Python 3.5, 3.6, and 3.7 are experimental.
265+
* Python 3.5, 3.6, 3.7, and 3.8 are experimental.
266266

267267
macOS users can install the `Xcode Command Line Tools` by running
268268
`xcode-select --install`. Alternatively, if you already have the full Xcode

configure

+2-1
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
# pyenv will alert which shims are available and then will fail the build.
88
_=[ 'exec' '/bin/sh' '-c' '''
99
test ${TRAVIS} && exec python "$0" "$@" # workaround for pyenv on Travis CI
10+
which python3.8 >/dev/null && exec python3.8 "$0" "$@"
1011
which python3.7 >/dev/null && exec python3.7 "$0" "$@"
1112
which python3.6 >/dev/null && exec python3.6 "$0" "$@"
1213
which python3.5 >/dev/null && exec python3.5 "$0" "$@"
@@ -20,7 +21,7 @@ import sys
2021
from distutils.spawn import find_executable
2122

2223
print('Node configure: Found Python {0}.{1}.{2}...'.format(*sys.version_info))
23-
acceptable_pythons = ((2, 7), (3, 7), (3, 6), (3, 5))
24+
acceptable_pythons = ((3, 8), (3, 7), (3, 6), (3, 5), (2, 7))
2425
if sys.version_info[:2] in acceptable_pythons:
2526
import configure
2627
else:

0 commit comments

Comments
 (0)