Skip to content

Commit 03e9352

Browse files
orangemochatrevnorris
authored andcommitted
win: manifest node.exe for Windows 8.1
Adding a compatibility section to node.exe embedded manifest so that Node is declared explicitly compatible with Windows 8.1. Required so that os.release() can return the correct version on Windows 8.1. See http://msdn.microsoft.com/en-us/library/windows/desktop/ms724451(v=vs.85).aspx Reviewed-by: Trevor Norris <[email protected]>
1 parent 378d972 commit 03e9352

File tree

2 files changed

+19
-0
lines changed

2 files changed

+19
-0
lines changed

node.gyp

+4
Original file line numberDiff line numberDiff line change
@@ -361,6 +361,10 @@
361361
'VCLinkerTool': {
362362
'SubSystem': 1, # /subsystem:console
363363
},
364+
'VCManifestTool': {
365+
'EmbedManifest': 'true',
366+
'AdditionalManifestFiles': 'src/res/node.exe.extra.manifest'
367+
}
364368
},
365369
},
366370
# generate ETW header and resource files

src/res/node.exe.extra.manifest

+15
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
<?xml version='1.0' encoding='UTF-8' standalone='yes'?>
2+
<assembly xmlns='urn:schemas-microsoft-com:asm.v1' manifestVersion='1.0'>
3+
<compatibility xmlns="urn:schemas-microsoft-com:compatibility.v1">
4+
<application>
5+
<!-- Windows 8.1 -->
6+
<supportedOS Id="{1f676c76-80e1-4239-95bb-83d0f6d0da78}"/>
7+
<!-- Windows 8 -->
8+
<supportedOS Id="{4a2f28e3-53b9-4441-ba9c-d69d4a4a6e38}"/>
9+
<!-- Windows 7 -->
10+
<supportedOS Id="{35138b9a-5d96-4fbd-8e2d-a2440225f93a}"/>
11+
<!-- Windows Vista -->
12+
<supportedOS Id="{e2011457-1546-43c5-a5fe-008deee3d3f0}"/>
13+
</application>
14+
</compatibility>
15+
</assembly>

0 commit comments

Comments
 (0)