Skip to content

Commit 053f3d6

Browse files
drewfishtargos
authored andcommitted
test: validate fs.rename() when NODE_TEST_DIR on separate mount
When testing fs.rename() of an non-existent file, use a destination path which is in the same directory. Otherwise we might trigger an `EXDEV` error if NODE_TEST_DIR is a separate device than the current working directory. Fixes: #21669 PR-URL: #24707 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
1 parent 68dc100 commit 053f3d6

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

test/parallel/test-fs-error-messages.js

+3-2
Original file line numberDiff line numberDiff line change
@@ -299,10 +299,11 @@ function re(literals, ...values) {
299299
return true;
300300
};
301301

302-
fs.rename(nonexistentFile, 'foo', common.mustCall(validateError));
302+
const destFile = path.join(tmpdir.path, 'foo');
303+
fs.rename(nonexistentFile, destFile, common.mustCall(validateError));
303304

304305
assert.throws(
305-
() => fs.renameSync(nonexistentFile, 'foo'),
306+
() => fs.renameSync(nonexistentFile, destFile),
306307
validateError
307308
);
308309
}

0 commit comments

Comments
 (0)