stream: fix error handling with async iteration

Fix an issue when an error was emitted by the stream before
`iterator.next()` is called.

PR-URL: #20329
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>

Author: julien-f

lib/internal/streams/async_iterator.js

@@ -58,7 +58,7 @@ function onError(iter, err) {
     iter[kLastReject] = null;
     reject(err);
   }
-  iter.error = err;
+  iter[kError] = err;
 }
 
 function wrapForNext(lastPromise, iter) {

test/parallel/test-stream-readable-async-iterators.js

@@ -115,6 +115,18 @@ async function tests() {
     readable.destroy(new Error('kaboom'));
   })();
 
+  await (async function() {
+    console.log('call next() after error');
+    const readable = new Readable({
+      read() {}
+    });
+    const iterator = readable[Symbol.asyncIterator]();
+
+    const err = new Error('kaboom');
+    readable.destroy(new Error('kaboom'));
+    await assert.rejects(iterator.next.bind(iterator), err);
+  })();
+
   await (async function() {
     console.log('read object mode');
     const max = 42;