Skip to content

Commit 07e9393

Browse files
weeweyevanlucas
authored andcommitted
test: use common.mustCall in test-https-strict
PR-URL: #12668 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent 76ab347 commit 07e9393

File tree

1 file changed

+2
-8
lines changed

1 file changed

+2
-8
lines changed

test/parallel/test-https-strict.js

+2-8
Original file line numberDiff line numberDiff line change
@@ -70,8 +70,6 @@ server2.listen(0, listening());
7070
server3.listen(0, listening());
7171

7272
const responseErrors = {};
73-
let expectResponseCount = 0;
74-
let responseCount = 0;
7573
let pending = 0;
7674

7775

@@ -126,17 +124,14 @@ function makeReq(path, port, error, host, ca) {
126124
options.headers = { host: host };
127125
}
128126
const req = https.get(options);
129-
expectResponseCount++;
130127
const server = port === server1.address().port ? server1 :
131128
port === server2.address().port ? server2 :
132129
port === server3.address().port ? server3 :
133130
null;
134-
135131
if (!server) throw new Error('invalid port: ' + port);
136132
server.expectCount++;
137133

138-
req.on('response', (res) => {
139-
responseCount++;
134+
req.on('response', common.mustCall((res) => {
140135
assert.strictEqual(res.connection.authorizationError, error);
141136
responseErrors[path] = res.connection.authorizationError;
142137
pending--;
@@ -146,7 +141,7 @@ function makeReq(path, port, error, host, ca) {
146141
server3.close();
147142
}
148143
res.resume();
149-
});
144+
}));
150145
}
151146

152147
function allListening() {
@@ -199,5 +194,4 @@ process.on('exit', () => {
199194
assert.strictEqual(server1.requests.length, server1.expectCount);
200195
assert.strictEqual(server2.requests.length, server2.expectCount);
201196
assert.strictEqual(server3.requests.length, server3.expectCount);
202-
assert.strictEqual(responseCount, expectResponseCount);
203197
});

0 commit comments

Comments
 (0)