Skip to content

Commit 07fd4cf

Browse files
mithunsasidharanMylesBorins
authored andcommitted
test: use common.mustCall in test-http-malformed-request
PR-URL: #17439 Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent 0ade488 commit 07fd4cf

File tree

1 file changed

+4
-13
lines changed

1 file changed

+4
-13
lines changed

test/parallel/test-http-malformed-request.js

+4-13
Original file line numberDiff line numberDiff line change
@@ -20,27 +20,22 @@
2020
// USE OR OTHER DEALINGS IN THE SOFTWARE.
2121

2222
'use strict';
23-
require('../common');
24-
const assert = require('assert');
23+
const common = require('../common');
2524
const net = require('net');
2625
const http = require('http');
2726
const url = require('url');
2827

2928
// Make sure no exceptions are thrown when receiving malformed HTTP
3029
// requests.
31-
32-
let nrequests_completed = 0;
33-
const nrequests_expected = 1;
34-
35-
const server = http.createServer(function(req, res) {
30+
const server = http.createServer(common.mustCall((req, res) => {
3631
console.log(`req: ${JSON.stringify(url.parse(req.url))}`);
3732

3833
res.writeHead(200, { 'Content-Type': 'text/plain' });
3934
res.write('Hello World');
4035
res.end();
4136

42-
if (++nrequests_completed === nrequests_expected) server.close();
43-
});
37+
server.close();
38+
}));
4439
server.listen(0);
4540

4641
server.on('listening', function() {
@@ -50,7 +45,3 @@ server.on('listening', function() {
5045
c.end();
5146
});
5247
});
53-
54-
process.on('exit', function() {
55-
assert.strictEqual(nrequests_expected, nrequests_completed);
56-
});

0 commit comments

Comments
 (0)