Skip to content

Commit 0825806

Browse files
committed
http2: do not modify explicity set date headers
Fixes: #30894 Refs: #29829
1 parent 307c67b commit 0825806

File tree

2 files changed

+47
-1
lines changed

2 files changed

+47
-1
lines changed

lib/internal/http2/core.js

+4-1
Original file line numberDiff line numberDiff line change
@@ -2234,7 +2234,10 @@ function processHeaders(oldHeaders) {
22342234
const statusCode =
22352235
headers[HTTP2_HEADER_STATUS] =
22362236
headers[HTTP2_HEADER_STATUS] | 0 || HTTP_STATUS_OK;
2237-
headers[HTTP2_HEADER_DATE] = utcDate();
2237+
2238+
if (headers[HTTP2_HEADER_DATE] === null ||
2239+
headers[HTTP2_HEADER_DATE] === undefined)
2240+
headers[HTTP2_HEADER_DATE] = utcDate();
22382241

22392242
// This is intentionally stricter than the HTTP/1 implementation, which
22402243
// allows values between 100 and 999 (inclusive) in order to allow for
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,43 @@
1+
// Copyright Joyent, Inc. and other Node contributors.
2+
//
3+
// Permission is hereby granted, free of charge, to any person obtaining a
4+
// copy of this software and associated documentation files (the
5+
// "Software"), to deal in the Software without restriction, including
6+
// without limitation the rights to use, copy, modify, merge, publish,
7+
// distribute, sublicense, and/or sell copies of the Software, and to permit
8+
// persons to whom the Software is furnished to do so, subject to the
9+
// following conditions:
10+
//
11+
// The above copyright notice and this permission notice shall be included
12+
// in all copies or substantial portions of the Software.
13+
//
14+
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
15+
// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
16+
// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN
17+
// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
18+
// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
19+
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
20+
// USE OR OTHER DEALINGS IN THE SOFTWARE.
21+
22+
'use strict';
23+
const common = require('../common');
24+
if (!common.hasCrypto) { common.skip('missing crypto'); }
25+
const assert = require('assert');
26+
const http2 = require('http2');
27+
28+
const server = http2.createServer(common.mustCall(function(request, response) {
29+
response.setHeader('date', 'snacks o clock');
30+
response.end();
31+
}));
32+
33+
server.listen(0, common.mustCall(function() {
34+
const session = http2.connect(`http://localhost:${server.address().port}`);
35+
const req = session.request();
36+
req.on('response', function(headers, flags) {
37+
assert.deepStrictEqual(headers.date, 'snacks o clock');
38+
});
39+
req.on('end', function() {
40+
session.close();
41+
server.close();
42+
});
43+
}));

0 commit comments

Comments
 (0)