Skip to content

Commit 08c6b21

Browse files
cjihrigBethGriggs
authored andcommittedDec 17, 2018
src: use Local version of ToBoolean()
This fixes a deprecation warning. PR-URL: #24924 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent 0220cd3 commit 08c6b21

File tree

1 file changed

+3
-9
lines changed

1 file changed

+3
-9
lines changed
 

‎src/js_native_api_v8.cc

+3-9
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,6 @@
1111
#define CHECK_TO_NUMBER(env, context, result, src) \
1212
CHECK_TO_TYPE((env), Number, (context), (result), (src), napi_number_expected)
1313

14-
#define CHECK_TO_BOOL(env, context, result, src) \
15-
CHECK_TO_TYPE((env), Boolean, (context), (result), (src), \
16-
napi_boolean_expected)
17-
1814
// n-api defines NAPI_AUTO_LENGHTH as the indicator that a string
1915
// is null terminated. For V8 the equivalent is -1. The assert
2016
// validates that our cast of NAPI_AUTO_LENGTH results in -1 as
@@ -2155,11 +2151,9 @@ napi_status napi_coerce_to_bool(napi_env env,
21552151
CHECK_ARG(env, value);
21562152
CHECK_ARG(env, result);
21572153

2158-
v8::Local<v8::Context> context = env->context();
2159-
v8::Local<v8::Boolean> b;
2160-
2161-
CHECK_TO_BOOL(env, context, b, value);
2162-
2154+
v8::Isolate* isolate = env->isolate;
2155+
v8::Local<v8::Boolean> b =
2156+
v8impl::V8LocalValueFromJsValue(value)->ToBoolean(isolate);
21632157
*result = v8impl::JsValueFromV8LocalValue(b);
21642158
return GET_RETURN_STATUS(env);
21652159
}

0 commit comments

Comments
 (0)
Please sign in to comment.