src: force line buffering for stderr

Trott · Trott · commit 0966ab99966b · 2015-11-10T17:52:44.000-08:00
SmartOS does not line buffer stderr by default, or at least that is the behavior on the Node project Jenkins server. Force line buffering. This resolves the flakiness observed on SmartOS for test-debug-signal-cluster. PR-URL: #3701 Fixes: #2476 Refs: #3615 Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
diff --git a/src/node_main.cc b/src/node_main.cc
@@ -41,6 +41,7 @@ int wmain(int argc, wchar_t *wargv[]) {
 #else
 // UNIX
 int main(int argc, char *argv[]) {
+  setvbuf(stderr, NULL, _IOLBF, 1024);
   return node::Start(argc, argv);
 }
 #endif
diff --git a/test/parallel/parallel.status b/test/parallel/parallel.status
@@ -18,7 +18,6 @@ test-child-process-exit-code      : PASS,FLAKY
 [$system==macos]
 
 [$system==solaris] # Also applies to SmartOS
-test-debug-signal-cluster         : PASS,FLAKY
 
 [$system==freebsd]
 test-net-socket-local-address     : PASS,FLAKY

Original file line number	Diff line number	Diff line change
`@@ -41,6 +41,7 @@ int wmain(int argc, wchar_t *wargv[]) {`
`41`	`41`	`#else`
`42`	`42`	`// UNIX`
`43`	`43`	`int main(int argc, char *argv[]) {`
	`44`	`+ setvbuf(stderr, NULL, _IOLBF, 1024);`
`44`	`45`	`return node::Start(argc, argv);`
`45`	`46`	`}`
`46`	`47`	`#endif`