Skip to content

Commit 097b8b4

Browse files
committed
doc: add note for features using InternalWorker with permission model
PR-URL: #56706 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
1 parent d066acf commit 097b8b4

File tree

2 files changed

+18
-0
lines changed

2 files changed

+18
-0
lines changed

doc/api/cli.md

+11
Original file line numberDiff line numberDiff line change
@@ -942,6 +942,10 @@ Previously gated the entire `import.meta.resolve` feature.
942942
<!-- YAML
943943
added: v8.8.0
944944
changes:
945+
- version: v23.6.1
946+
pr-url: https://github.com/nodejs-private/node-private/pull/629
947+
description: Using this feature with the permission model enabled requires
948+
passing `--allow-worker`.
945949
- version: v12.11.1
946950
pr-url: https://github.com/nodejs/node/pull/29752
947951
description: This flag was renamed from `--loader` to
@@ -955,6 +959,8 @@ changes:
955959
Specify the `module` containing exported [module customization hooks][].
956960
`module` may be any string accepted as an [`import` specifier][].
957961

962+
This feature requires `--allow-worker` if used with the [Permission Model][].
963+
958964
### `--experimental-network-inspection`
959965

960966
<!-- YAML
@@ -1044,6 +1050,11 @@ report is not generated. See the documentation on
10441050
added:
10451051
- v22.3.0
10461052
- v20.18.0
1053+
changes:
1054+
- version: v23.6.1
1055+
pr-url: https://github.com/nodejs-private/node-private/pull/629
1056+
description: Using this feature with the permission model enabled requires
1057+
passing `--allow-worker`.
10471058
-->
10481059

10491060
> Stability: 1.0 - Early development

doc/api/module.md

+7
Original file line numberDiff line numberDiff line change
@@ -177,6 +177,10 @@ added:
177177
- v20.6.0
178178
- v18.19.0
179179
changes:
180+
- version: v23.6.1
181+
pr-url: https://github.com/nodejs-private/node-private/pull/629
182+
description: Using this feature with the permission model enabled requires
183+
passing `--allow-worker`.
180184
- version:
181185
- v20.8.0
182186
- v18.19.0
@@ -205,6 +209,8 @@ changes:
205209
Register a module that exports [hooks][] that customize Node.js module
206210
resolution and loading behavior. See [Customization hooks][].
207211
212+
This feature requires `--allow-worker` if used with the [Permission Model][].
213+
208214
### `module.registerHooks(options)`
209215
210216
<!-- YAML
@@ -1699,6 +1705,7 @@ returned object contains the following keys:
16991705
[Conditional exports]: packages.md#conditional-exports
17001706
[Customization hooks]: #customization-hooks
17011707
[ES Modules]: esm.md
1708+
[Permission Model]: permissions.md#permission-model
17021709
[Source map v3 format]: https://sourcemaps.info/spec.html#h.mofvlxcwqzej
17031710
[V8 JavaScript code coverage]: https://v8project.blogspot.com/2017/12/javascript-code-coverage.html
17041711
[V8 code cache]: https://v8.dev/blog/code-caching-for-devs

0 commit comments

Comments
 (0)