Skip to content

Commit 098a5b1

Browse files
oleavrcodebytere
authored andcommitted
deps: V8: cherry-pick 086eecbd96b6
Original commit message: [platform] Add Permission::kNoAccessWillJitLater enum value This value is unused for now. This CL is part 1 of a 3-step dance. Part 2 will be teaching Chrome's Platform implementation to accept the new value. Part 3 will then actually use it in V8. Bug: chromium:1117591 Change-Id: Ie3aed20d4cc58f3def3be2a3a03bba4c3a37bf44 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2450056 Commit-Queue: Jakob Kummerow <[email protected]> Reviewed-by: Michael Lippautz <[email protected]> Cr-Commit-Position: refs/heads/master@{#70335} PR-URL: #35986 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
1 parent d2c757a commit 098a5b1

File tree

3 files changed

+9
-2
lines changed

3 files changed

+9
-2
lines changed

common.gypi

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636

3737
# Reset this number to 0 on major V8 upgrades.
3838
# Increment by one for each non-official patch applied to deps/v8.
39-
'v8_embedder_string': '-node.18',
39+
'v8_embedder_string': '-node.19',
4040

4141
##### V8 defaults for Node.js #####
4242

deps/v8/include/v8-platform.h

+7-1
Original file line numberDiff line numberDiff line change
@@ -384,7 +384,13 @@ class PageAllocator {
384384
kReadWrite,
385385
// TODO(hpayer): Remove this flag. Memory should never be rwx.
386386
kReadWriteExecute,
387-
kReadExecute
387+
kReadExecute,
388+
// Set this when reserving memory that will later require kReadWriteExecute
389+
// permissions. The resulting behavior is platform-specific, currently
390+
// this is used to set the MAP_JIT flag on Apple Silicon.
391+
// TODO(jkummerow): Remove this when Wasm has a platform-independent
392+
// w^x implementation.
393+
kNoAccessWillJitLater
388394
};
389395

390396
/**

deps/v8/test/unittests/heap/unmapper-unittest.cc

+1
Original file line numberDiff line numberDiff line change
@@ -170,6 +170,7 @@ class TrackingPageAllocator : public ::v8::PageAllocator {
170170
os << " page: [" << start << ", " << end << "), access: ";
171171
switch (access) {
172172
case PageAllocator::kNoAccess:
173+
case PageAllocator::kNoAccessWillJitLater:
173174
os << "--";
174175
break;
175176
case PageAllocator::kRead:

0 commit comments

Comments
 (0)