Skip to content

Commit 0a265df

Browse files
ipotuzhnovmhdawson
authored andcommitted
test: Modernize test-tls-peer-certificate.js
Modernize `test/parallel/test-tls-peer-certificate.js` according to the following rules: * `var` --> `const`/`let` * `assert.equal` --> `assert.strictEqual` * `assert.ok(a === b)` --> `assert.strictEqual(a, b)` PR-URL: #10014 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-by: Michael Dawson <[email protected]>
1 parent fc31055 commit 0a265df

File tree

1 file changed

+20
-18
lines changed

1 file changed

+20
-18
lines changed

test/parallel/test-tls-peer-certificate.js

+20-18
Original file line numberDiff line numberDiff line change
@@ -1,50 +1,52 @@
11
'use strict';
2-
var common = require('../common');
3-
var assert = require('assert');
2+
const common = require('../common');
3+
const assert = require('assert');
44

55
if (!common.hasCrypto) {
66
common.skip('missing crypto');
77
return;
88
}
9-
var tls = require('tls');
9+
const tls = require('tls');
1010

11-
var fs = require('fs');
12-
var util = require('util');
13-
var join = require('path').join;
11+
const fs = require('fs');
12+
const util = require('util');
13+
const join = require('path').join;
1414

15-
var options = {
15+
const options = {
1616
key: fs.readFileSync(join(common.fixturesDir, 'keys', 'agent1-key.pem')),
1717
cert: fs.readFileSync(join(common.fixturesDir, 'keys', 'agent1-cert.pem')),
1818
ca: [ fs.readFileSync(join(common.fixturesDir, 'keys', 'ca1-cert.pem')) ]
1919
};
2020

21-
var server = tls.createServer(options, function(cleartext) {
21+
const server = tls.createServer(options, function(cleartext) {
2222
cleartext.end('World');
2323
});
2424
server.listen(0, common.mustCall(function() {
25-
var socket = tls.connect({
25+
const socket = tls.connect({
2626
port: this.address().port,
2727
rejectUnauthorized: false
2828
}, common.mustCall(function() {
29-
var peerCert = socket.getPeerCertificate();
29+
let peerCert = socket.getPeerCertificate();
3030
assert.ok(!peerCert.issuerCertificate);
3131

3232
// Verify that detailed return value has all certs
3333
peerCert = socket.getPeerCertificate(true);
3434
assert.ok(peerCert.issuerCertificate);
3535

3636
console.error(util.inspect(peerCert));
37-
assert.equal(peerCert.subject.emailAddress, '[email protected]');
38-
assert.equal(peerCert.serialNumber, '9A84ABCFB8A72AC0');
39-
assert.equal(peerCert.exponent, '0x10001');
40-
assert.equal(peerCert.fingerprint,
41-
'8D:06:3A:B3:E5:8B:85:29:72:4F:7D:1B:54:CD:95:19:3C:EF:6F:AA');
37+
assert.strictEqual(peerCert.subject.emailAddress, '[email protected]');
38+
assert.strictEqual(peerCert.serialNumber, '9A84ABCFB8A72AC0');
39+
assert.strictEqual(peerCert.exponent, '0x10001');
40+
assert.strictEqual(
41+
peerCert.fingerprint,
42+
'8D:06:3A:B3:E5:8B:85:29:72:4F:7D:1B:54:CD:95:19:3C:EF:6F:AA'
43+
);
4244
assert.deepStrictEqual(peerCert.infoAccess['OCSP - URI'],
4345
[ 'http://ocsp.nodejs.org/' ]);
4446

45-
var issuer = peerCert.issuerCertificate;
46-
assert.ok(issuer.issuerCertificate === issuer);
47-
assert.equal(issuer.serialNumber, '8DF21C01468AF393');
47+
const issuer = peerCert.issuerCertificate;
48+
assert.strictEqual(issuer.issuerCertificate, issuer);
49+
assert.strictEqual(issuer.serialNumber, '8DF21C01468AF393');
4850
server.close();
4951
}));
5052
socket.end('Hello');

0 commit comments

Comments
 (0)