Skip to content

Commit 0aa339e

Browse files
danbevtargos
authored andcommitted
test: skip test-fs-access if root
Currently, if this test is run as the root user the following failure will occur: === release test-fs-access === Path: parallel/test-fs-access (node:46733) internal/test/binding: These APIs are for internal testing only. Do not use them. Can't clean tmpdir: /root/node/test/.tmp.522 Files blocking: [ 'read_only_file', 'read_write_file' ] /root/node/test/common/tmpdir.js:136 throw e; ^ Error: EACCES: permission denied, rmdir '/root/node/test/.tmp.522' at Object.rmdirSync (fs.js:693:3) at rmdirSync (/root/node/test/common/tmpdir.js:72:8) at rimrafSync (/root/node/test/common/tmpdir.js:41:7) at process.onexit (/root/node/test/common/tmpdir.js:121:5) at process.emit (events.js:214:15) { errno: -13, syscall: 'rmdir', code: 'EACCES', path: '/root/node/test/.tmp.522' } Command: ./node --expose-internals test/parallel/test-fs-access.js This commit adds a root user check and skips this test if running as the user root. PR-URL: #29092 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
1 parent c7a4525 commit 0aa339e

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

test/parallel/test-fs-access.js

+3
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,9 @@
55
// and the errors thrown from these APIs include the desired properties
66

77
const common = require('../common');
8+
if (!common.isWindows && process.getuid() === 0)
9+
common.skip('as this test should not be run as `root`');
10+
811
const assert = require('assert');
912
const fs = require('fs');
1013
const path = require('path');

0 commit comments

Comments
 (0)