Skip to content

Commit 0c391fb

Browse files
richardlauGabriel Schulhof
authored and
Gabriel Schulhof
committed
build: fix building with ninja
The ninja build places objects in a different directory. Co-authored-by: Gabriel Schulhof <[email protected]> Signed-off-by: Richard Lau <[email protected]> PR-URL: #32071 Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
1 parent f2572a1 commit 0c391fb

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

node.gyp

+6-1
Original file line numberDiff line numberDiff line change
@@ -244,6 +244,11 @@
244244
'node_mksnapshot_exec': '<(PRODUCT_DIR)/<(EXECUTABLE_PREFIX)node_mksnapshot<(EXECUTABLE_SUFFIX)',
245245
'mkcodecache_exec': '<(PRODUCT_DIR)/<(EXECUTABLE_PREFIX)mkcodecache<(EXECUTABLE_SUFFIX)',
246246
'conditions': [
247+
['GENERATOR == "ninja"', {
248+
'node_text_start_object_path': 'src/large_pages/node_text_start.node_text_start.o'
249+
}, {
250+
'node_text_start_object_path': 'node_text_start/src/large_pages/node_text_start.o'
251+
}],
247252
[ 'node_shared=="true"', {
248253
'node_target_type%': 'shared_library',
249254
'conditions': [
@@ -509,7 +514,7 @@
509514
'target_arch=="x64"', {
510515
'dependencies': [ 'node_text_start' ],
511516
'ldflags+': [
512-
'<(PRODUCT_DIR)/obj.target/node_text_start/src/large_pages/node_text_start.o'
517+
'<(obj_dir)/<(node_text_start_object_path)'
513518
]
514519
}],
515520
],

0 commit comments

Comments
 (0)