Skip to content

Commit 0df6c0b

Browse files
committed
Revert "readline: clean up event listener in onNewListener"
This reverts commit 81ddeb9. Ref: #13266 PR-URL: #13560 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
1 parent 53ec50d commit 0df6c0b

File tree

2 files changed

+2
-7
lines changed

2 files changed

+2
-7
lines changed

lib/readline.js

-3
Original file line numberDiff line numberDiff line change
@@ -1039,9 +1039,6 @@ function emitKeypressEvents(stream, iface) {
10391039
} else {
10401040
stream.on('newListener', onNewListener);
10411041
}
1042-
if (iface) {
1043-
iface.once('close', () => { stream.removeListener('data', onData); });
1044-
}
10451042
}
10461043

10471044
/**

test/parallel/test-readline-set-raw-mode.js

+2-4
Original file line numberDiff line numberDiff line change
@@ -74,8 +74,6 @@ assert(!rawModeCalled);
7474
assert(resumeCalled);
7575
assert(!pauseCalled);
7676

77-
// One data listener for the keypress events.
78-
assert.strictEqual(stream.listeners('data').length, 1);
7977

8078
// close() should call setRawMode(false)
8179
expectedRawMode = false;
@@ -88,5 +86,5 @@ assert(!resumeCalled);
8886
assert(pauseCalled);
8987

9088
assert.deepStrictEqual(stream.listeners('keypress'), []);
91-
// Data listener is removed once interface is closed.
92-
assert.strictEqual(stream.listeners('data').length, 0);
89+
// one data listener for the keypress events.
90+
assert.strictEqual(stream.listeners('data').length, 1);

0 commit comments

Comments
 (0)