Skip to content

Commit 0f290f2

Browse files
Trottevanlucas
authored andcommitted
test: enable setuid/setgid test
Refactor test for situations where it was expected to fail. Move from disabled directory to parallel. PR-URL: #12403 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
1 parent 4570d98 commit 0f290f2

File tree

2 files changed

+47
-23
lines changed

2 files changed

+47
-23
lines changed

test/disabled/test-setuidgid.js

-23
This file was deleted.
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,47 @@
1+
'use strict';
2+
const common = require('../common');
3+
4+
const assert = require('assert');
5+
6+
if (common.isWindows) {
7+
// uid/gid functions are POSIX only
8+
assert.strictEqual(process.getuid, undefined);
9+
assert.strictEqual(process.setuid, undefined);
10+
assert.strictEqual(process.getgid, undefined);
11+
assert.strictEqual(process.setgid, undefined);
12+
return;
13+
}
14+
15+
assert.throws(() => {
16+
process.setuid('fhqwhgadshgnsdhjsdbkhsdabkfabkveybvf');
17+
}, /^Error: setuid user id does not exist$/);
18+
19+
// If we're not running as super user...
20+
if (process.getuid() !== 0) {
21+
assert.doesNotThrow(() => {
22+
process.getgid();
23+
process.getuid();
24+
});
25+
26+
assert.throws(
27+
() => { process.setgid('nobody'); },
28+
/^Error: (EPERM, .+|setgid group id does not exist)$/
29+
);
30+
31+
assert.throws(
32+
() => { process.setuid('nobody'); },
33+
/^Error: EPERM, /
34+
);
35+
return;
36+
}
37+
38+
// If we are running as super user...
39+
const oldgid = process.getgid();
40+
process.setgid('nobody');
41+
const newgid = process.getgid();
42+
assert.notStrictEqual(newgid, oldgid);
43+
44+
const olduid = process.getuid();
45+
process.setuid('nobody');
46+
const newuid = process.getuid();
47+
assert.notStrictEqual(newuid, olduid);

0 commit comments

Comments
 (0)