Skip to content

Commit 0f3cf7e

Browse files
StefanStojanovicruyadorno
authored andcommitted
Revert "build: remove precompiled header and debug information for host builds"
This reverts commit 818284b. Reverted commit is a no longer needed patch for ARM64 cross-compiling. It was increasing cross-compile time drastically (~3 times longer). PR-URL: #45432 Refs: #42538 Refs: #42375 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Stewart X Addison <[email protected]>
1 parent 8d96e2c commit 0f3cf7e

File tree

2 files changed

+6
-12
lines changed

2 files changed

+6
-12
lines changed

common.gypi

+1-5
Original file line numberDiff line numberDiff line change
@@ -283,11 +283,7 @@
283283
'-std:c++17'
284284
],
285285
'BufferSecurityCheck': 'true',
286-
'target_conditions': [
287-
['_toolset=="target"', {
288-
'DebugInformationFormat': 1 # /Z7 embed info in .obj files
289-
}],
290-
],
286+
'DebugInformationFormat': 1, # /Z7 embed info in .obj files
291287
'ExceptionHandling': 0, # /EHsc
292288
'MultiProcessorCompilation': 'true',
293289
'StringPooling': 'true', # pool string literals

tools/v8_gypfiles/v8.gyp

+5-7
Original file line numberDiff line numberDiff line change
@@ -325,7 +325,7 @@
325325
'<(V8_ROOT)/src/builtins/builtins-intl-gen.cc',
326326
],
327327
}],
328-
['OS=="win" and _toolset=="target"', {
328+
['OS=="win"', {
329329
'msvs_precompiled_header': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.h',
330330
'msvs_precompiled_source': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.cc',
331331
'sources': [
@@ -683,7 +683,7 @@
683683
],
684684
'sources': ['<@(v8_compiler_sources)'],
685685
'conditions': [
686-
['OS=="win" and _toolset=="target"', {
686+
['OS=="win"', {
687687
'msvs_precompiled_header': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.h',
688688
'msvs_precompiled_source': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.cc',
689689
'sources': [
@@ -708,7 +708,7 @@
708708
],
709709
'sources': ['<@(v8_compiler_sources)'],
710710
'conditions': [
711-
['OS=="win" and _toolset=="target"', {
711+
['OS=="win"', {
712712
'msvs_precompiled_header': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.h',
713713
'msvs_precompiled_source': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.cc',
714714
'sources': [
@@ -908,15 +908,13 @@
908908
'<!@pymod_do_main(GN-scraper "<(V8_ROOT)/BUILD.gn" "\\"v8_base_without_compiler.*?v8_current_cpu == \\"loong64\\".*?sources \\+= ")',
909909
],
910910
}],
911-
['OS=="win" and _toolset=="target"', {
911+
['OS=="win"', {
912912
'msvs_precompiled_header': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.h',
913913
'msvs_precompiled_source': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.cc',
914914
'sources': [
915915
'<(_msvs_precompiled_header)',
916916
'<(_msvs_precompiled_source)',
917-
]
918-
}],
919-
['OS=="win"', {
917+
],
920918
# This will prevent V8's .cc files conflicting with the inspector's
921919
# .cpp files in the same shard.
922920
'msvs_settings': {

0 commit comments

Comments
 (0)