File tree 2 files changed +3
-3
lines changed
2 files changed +3
-3
lines changed Original file line number Diff line number Diff line change @@ -92,7 +92,7 @@ make clean
92
92
tools/license-builder.sh
93
93
```
94
94
95
- - Now, fix the default URL for the ` full-icu ` build in ` /configure ` , in
95
+ - Now, fix the default URL for the ` full-icu ` build in ` /configure.py ` , in
96
96
the ` configure_intl() ` function. It should match the ICU URL used in the
97
97
first step. When this is done, the following should build with full ICU.
98
98
104
104
make test-ci
105
105
```
106
106
107
- - commit the change to ` configure ` along with the updated ` LICENSE ` file.
107
+ - commit the change to ` configure.py ` along with the updated ` LICENSE ` file.
108
108
109
109
- Note: To simplify review, I often will “pre-land” this patch, meaning that
110
110
I run the patch through `curl -L https://github.com/nodejs/node/pull/xxx.patch
Original file line number Diff line number Diff line change 22
22
parser .add_option ('--icutmp' ,
23
23
action = 'store' ,
24
24
dest = 'icutmp' ,
25
- default = 'out/Release/gen/icutmp' ,
25
+ default = 'out/Release/obj/ gen/icutmp' ,
26
26
help = 'path to icutmp dir.' )
27
27
28
28
You can’t perform that action at this time.
0 commit comments