Skip to content

Commit 1033f6c

Browse files
DeeDeeGtargos
authored andcommitted
tools: add _depot_tools to PATH (for V8 tests)
Ensures the `_depot_tools` dir bootstrapped during this script is added to the PATH, before `ninja` is executed, as `_depot_tools` already has a copy of `ninja` in it. This means one less system requirement to be able to run this script. (It seems like this was already intended to be on the PATH?) Note: This script is used by the `test-v8` Makefile target. PR-URL: #38299 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent f6f1317 commit 1033f6c

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

tools/make-v8.sh

+3-2
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,8 @@ if [ "$ARCH" = "s390x" ] || [ "$ARCH" = "ppc64le" ]; then
3636
gn gen -v "out.gn/$BUILD_ARCH_TYPE" --args="is_component_build=false is_debug=false use_goma=false goma_dir=\"None\" use_custom_libcxx=false v8_target_cpu=\"$TARGET_ARCH\" target_cpu=\"$TARGET_ARCH\" v8_enable_backtrace=true"
3737
ninja -v -C "out.gn/$BUILD_ARCH_TYPE" d8 cctest inspector-test
3838
else
39+
DEPOT_TOOLS_DIR="$(cd _depot_tools && pwd)"
3940
# shellcheck disable=SC2086
40-
PATH=~/_depot_tools:$PATH tools/dev/v8gen.py "$BUILD_ARCH_TYPE" --no-goma $V8_BUILD_OPTIONS
41-
PATH=~/_depot_tools:$PATH ninja -C "out.gn/$BUILD_ARCH_TYPE/" d8 cctest inspector-test
41+
PATH="$DEPOT_TOOLS_DIR":$PATH tools/dev/v8gen.py "$BUILD_ARCH_TYPE" --no-goma $V8_BUILD_OPTIONS
42+
PATH="$DEPOT_TOOLS_DIR":$PATH ninja -C "out.gn/$BUILD_ARCH_TYPE/" d8 cctest inspector-test
4243
fi

0 commit comments

Comments
 (0)