Skip to content

Commit 103a9af

Browse files
cjihrigcodebytere
authored andcommitted
inspector: drop 'chrome-' from inspector url
It has been reported that the https://github.com/cjihrig/node-v8-inspector V8 inspector extension can no longer connect DevTools (despite no code changes to the extension since Feb. 2017). Upon investigation, Chrome dropped support for the chrome-devtools: scheme recently. I've confirmed that dropping 'chrome-' from the URL here allows the debugger to function properly with modern Chrome. Refs: https://chromium.googlesource.com/chromium/src/+/6700d12448f76712c62a6d2372a95b97a26d4779 PR-URL: #33758 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Eugene Ostroukhov <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: David Carlier <[email protected]>
1 parent 046dee6 commit 103a9af

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/inspector_socket_server.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -373,7 +373,7 @@ void InspectorSocketServer::SendListResponse(InspectorSocket* socket,
373373
std::string InspectorSocketServer::GetFrontendURL(bool is_compat,
374374
const std::string &formatted_address) {
375375
std::ostringstream frontend_url;
376-
frontend_url << "chrome-devtools://devtools/bundled/";
376+
frontend_url << "devtools://devtools/bundled/";
377377
frontend_url << (is_compat ? "inspector" : "js_app");
378378
frontend_url << ".html?experiments=true&v8only=true&ws=";
379379
frontend_url << formatted_address;

0 commit comments

Comments
 (0)