Skip to content

Commit 11a7875

Browse files
targosgibfahn
authored andcommitted
doc: upgrade Clang requirement to 3.4.2
Clang 3.4.1 has a bug that prevents compilation of V8. As of Node.js 8.0.0 we stopped floating a workaround for this issue. PR-URL: #12388 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]>
1 parent 7fc0946 commit 11a7875

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

BUILDING.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -62,8 +62,8 @@ Depending on host platform, the selection of toolchains may vary.
6262

6363
#### Unix
6464

65-
* GCC 4.8 or newer
66-
* Clang 3.4 or newer
65+
* GCC 4.8.5 or newer
66+
* Clang 3.4.2 or newer
6767

6868
#### Windows
6969

@@ -78,7 +78,7 @@ Depending on host platform, the selection of toolchains may vary.
7878
Prerequisites:
7979

8080
* `gcc` and `g++` 4.8.5 or newer, or
81-
* `clang` and `clang++` 3.4 or newer
81+
* `clang` and `clang++` 3.4.2 or newer
8282
* Python 2.6 or 2.7
8383
* GNU Make 3.81 or newer
8484

configure

+2-2
Original file line numberDiff line numberDiff line change
@@ -617,8 +617,8 @@ def check_compiler(o):
617617
ok, is_clang, clang_version, gcc_version = try_check_compiler(CXX, 'c++')
618618
if not ok:
619619
warn('failed to autodetect C++ compiler version (CXX=%s)' % CXX)
620-
elif clang_version < '3.4.0' if is_clang else gcc_version < '4.8.0':
621-
warn('C++ compiler too old, need g++ 4.8 or clang++ 3.4 (CXX=%s)' % CXX)
620+
elif clang_version < '3.4.2' if is_clang else gcc_version < '4.8.0':
621+
warn('C++ compiler too old, need g++ 4.8 or clang++ 3.4.2 (CXX=%s)' % CXX)
622622

623623
ok, is_clang, clang_version, gcc_version = try_check_compiler(CC, 'c')
624624
if not ok:

0 commit comments

Comments
 (0)