Skip to content

Commit 11c6745

Browse files
vsemozhetbyttargos
authored andcommitted
doc: update author-ready label terms
PR-URL: #23249 Refs: #22255 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
1 parent 33e3eb4 commit 11c6745

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

COLLABORATOR_GUIDE.md

+5-4
Original file line numberDiff line numberDiff line change
@@ -83,10 +83,11 @@ necessary.
8383
### Author ready pull requests
8484

8585
A pull request that is still awaiting the minimum review time is considered
86-
_author ready_ as soon as the CI has been started, it has at least one approval,
87-
and it has no outstanding review comments. Please always make sure to add the
88-
`author ready` label to the PR in that case and remove it again as soon as that
89-
condition is not met anymore.
86+
_author ready_ as soon as the CI has been started, it has at least two approvals
87+
(one Collaborator approval is enough if the pull request has been open for more
88+
than 7 days), and it has no outstanding review comments. Please always make sure
89+
to add the `author ready` label to the PR in that case and remove it again as
90+
soon as that condition is not met anymore.
9091

9192
### Handling own pull requests
9293

doc/onboarding.md

+2-1
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,8 @@ onboarding session.
9999
* Please add the `author-ready` label for PRs where:
100100
* the CI has been started (not necessarily finished),
101101
* no outstanding review comments exist and
102-
* at least one collaborator approved the PR.
102+
* at least two Collaborators approved the PR (one Collaborator approval is
103+
enough if the pull request has been open for more than 7 days).
103104

104105
* See [Who to CC in the issue tracker][who-to-cc].
105106
* This will come more naturally over time

0 commit comments

Comments
 (0)