Skip to content

Commit 11f4562

Browse files
vsemozhetbytaddaleax
authored andcommitted
benchmark: remove needless RegExp capturing
Use non-capturing grouping or remove capturing completely when: * capturing is useless per se, e.g. in test() check; * captured groups are not used afterwards at all; * some of the later captured groups are not used afterwards. PR-URL: #13718 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
1 parent d4a05b2 commit 11f4562

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

benchmark/common.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -217,7 +217,7 @@ function formatResult(data) {
217217
}
218218

219219
var rate = data.rate.toString().split('.');
220-
rate[0] = rate[0].replace(/(\d)(?=(\d\d\d)+(?!\d))/g, '$1,');
220+
rate[0] = rate[0].replace(/(\d)(?=(?:\d\d\d)+(?!\d))/g, '$1,');
221221
rate = (rate[1] ? rate.join('.') : rate[0]);
222222
return `${data.name}${conf}: ${rate}`;
223223
}

benchmark/run.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ if (format === 'csv') {
6060
console.log(`"${data.name}", "${conf}", ${data.rate}, ${data.time}`);
6161
} else {
6262
var rate = data.rate.toString().split('.');
63-
rate[0] = rate[0].replace(/(\d)(?=(\d\d\d)+(?!\d))/g, '$1,');
63+
rate[0] = rate[0].replace(/(\d)(?=(?:\d\d\d)+(?!\d))/g, '$1,');
6464
rate = (rate[1] ? rate.join('.') : rate[0]);
6565
console.log(`${data.name} ${conf}: ${rate}`);
6666
}

0 commit comments

Comments
 (0)