Skip to content

Commit 11f5924

Browse files
masx200danielleadams
authored andcommitted
http2: add has method to proxySocketHandler
PR-URL: #35197 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Rich Trott <[email protected]>
1 parent 71fa9c6 commit 11f5924

File tree

2 files changed

+44
-0
lines changed

2 files changed

+44
-0
lines changed

lib/internal/http2/compat.js

+5
Original file line numberDiff line numberDiff line change
@@ -188,6 +188,11 @@ function resumeStream(stream) {
188188
}
189189

190190
const proxySocketHandler = {
191+
has(stream, prop) {
192+
const ref = stream.session !== undefined ? stream.session[kSocket] : stream;
193+
return (prop in stream) || (prop in ref);
194+
},
195+
191196
get(stream, prop) {
192197
switch (prop) {
193198
case 'on':
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,39 @@
1+
'use strict';
2+
const common = require('../common');
3+
if (!common.hasCrypto) {
4+
common.skip('missing crypto');
5+
}
6+
7+
const fixtures = require('../common/fixtures');
8+
const assert = require('assert');
9+
const http2 = require('http2');
10+
11+
const serverOptions = {
12+
key: fixtures.readKey('agent1-key.pem'),
13+
cert: fixtures.readKey('agent1-cert.pem')
14+
};
15+
const server = http2.createSecureServer(serverOptions, common.mustCall(
16+
(req, res) => {
17+
const request = req;
18+
assert.strictEqual(request.socket.encrypted, true);
19+
assert.ok('encrypted' in request.socket);
20+
res.end();
21+
}
22+
));
23+
server.listen(common.mustCall(() => {
24+
const port = server.address().port;
25+
const client = http2.connect('https://localhost:' + port, {
26+
ca: fixtures.readKey('agent1-cert.pem'),
27+
rejectUnauthorized: false
28+
});
29+
const req = client.request({});
30+
req.on('response', common.mustCall((headers, flags) => {
31+
console.log(headers);
32+
server.close(common.mustCall(() => {
33+
}));
34+
}));
35+
req.on('end', common.mustCall(() => {
36+
client.close();
37+
}));
38+
req.end();
39+
}));

0 commit comments

Comments
 (0)