Skip to content

Commit 12657ac

Browse files
hrishikesh-kadamdanielleadams
authored andcommitted
build: add .gitattributes for npm and other shims
This issue has been described in - #43860 On Windows system, git clone or git checkout on the repo turns LF line endings to CRLF in the worktree. This can happen due to many reasons like - - git config --system core.autocrlf (set to true) - git config --global core.autocrlf (set to true) - git config --local core.autocrlf (set to true) - git clone --config core.autocrlf=true ... Adding gitattributes for the shims will not convert them to CRLF line endings. Also, there is a note[1] in test/README.md which says - For the tests to run on Windows, be sure to clone Node.js source code with the `autocrlf` git config flag set to true. Reason for using build subsystem - These shims are just copied in stage_package label of vcbuild.bat Fixes: #43860 [1]: 3654cd4 PR-URL: #43879 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
1 parent aac97c2 commit 12657ac

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

.gitattributes

+3
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
11
test/fixtures/* -text
22
vcbuild.bat text eol=crlf
3+
deps/npm/bin/npm text eol=lf
4+
deps/npm/bin/npx text eol=lf
5+
deps/corepack/shims/corepack text eol=lf
36
tools/msvs/find_python.cmd text eol=crlf

0 commit comments

Comments
 (0)