Skip to content

Commit 130777a

Browse files
Trotttargos
authored andcommitted
doc: update BUILDING.md section on running tests
Refs: #40920 PR-URL: #40933 Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
1 parent 6ebbd0d commit 130777a

File tree

1 file changed

+17
-15
lines changed

1 file changed

+17
-15
lines changed

BUILDING.md

+17-15
Original file line numberDiff line numberDiff line change
@@ -143,8 +143,8 @@ platforms. This is true regardless of entries in the table below.
143143
community will only address issues that reproduce on native GNU/Linux
144144
systems. Issues that only reproduce on WSL should be reported in the
145145
[WSL issue tracker](https://github.com/Microsoft/WSL/issues). Running the
146-
Windows binary (`node.exe`) in WSL is not recommended. It will not work
147-
without workarounds such as stdio redirection.
146+
Windows binary (`node.exe`) in WSL will not work without workarounds such as
147+
stdio redirection.
148148

149149
[^6]: Running Node.js on x86 Windows should work and binaries
150150
are provided. However, tests in our infrastructure only run on WoW64.
@@ -306,8 +306,7 @@ $ make test-only
306306

307307
At this point, you are ready to make code changes and re-run the tests.
308308

309-
If you are running tests before submitting a pull request, the recommended
310-
command is:
309+
If you are running tests before submitting a pull request, use:
311310

312311
```console
313312
$ make -j4 test
@@ -316,31 +315,34 @@ $ make -j4 test
316315
`make -j4 test` does a full check on the codebase, including running linters and
317316
documentation tests.
318317

319-
Make sure the linter does not report any issues and that all tests pass. Please
320-
do not submit patches that fail either check.
321-
322-
If you want to run the linter without running tests, use
318+
To run the linter without running tests, use
323319
`make lint`/`vcbuild lint`. It will lint JavaScript, C++, and Markdown files.
324320

325321
If you are updating tests and want to run tests in a single test file
326322
(e.g. `test/parallel/test-stream2-transform.js`):
327323

328324
```text
329-
$ python tools/test.py test/parallel/test-stream2-transform.js
325+
$ tools/test.py test/parallel/test-stream2-transform.js
330326
```
331327

332328
You can execute the entire suite of tests for a given subsystem
333329
by providing the name of a subsystem:
334330

335331
```text
336-
$ python tools/test.py -J --mode=release child-process
332+
$ tools/test.py -J child-process
333+
```
334+
335+
You can also execute the tests in a tests directory (such as `test/message`):
336+
337+
```text
338+
$ tools/test.py -J test/message
337339
```
338340

339341
If you want to check the other options, please refer to the help by using
340342
the `--help` option:
341343

342344
```text
343-
$ python tools/test.py --help
345+
$ tools/test.py --help
344346
```
345347

346348
You can usually run tests directly with node:
@@ -355,7 +357,7 @@ the `lib` or `src` directories.
355357
The tests attempt to detect support for IPv6 and exclude IPv6 tests if
356358
appropriate. If your main interface has IPv6 addresses, then your
357359
loopback interface must also have '::1' enabled. For some default installations
358-
on Ubuntu that does not seem to be the case. To enable '::1' on the
360+
on Ubuntu, that does not seem to be the case. To enable '::1' on the
359361
loopback interface on Ubuntu:
360362

361363
```bash
@@ -364,7 +366,7 @@ sudo sysctl -w net.ipv6.conf.lo.disable_ipv6=0
364366

365367
You can use
366368
[node-code-ide-configs](https://github.com/nodejs/node-code-ide-configs)
367-
to run/debug tests, if your IDE configs are present.
369+
to run/debug tests if your IDE configs are present.
368370

369371
#### Running coverage
370372

@@ -392,7 +394,7 @@ If you are updating tests and want to collect coverage for a single test file
392394

393395
```text
394396
$ make coverage-clean
395-
$ NODE_V8_COVERAGE=coverage/tmp python tools/test.py test/parallel/test-stream2-transform.js
397+
$ NODE_V8_COVERAGE=coverage/tmp tools/test.py test/parallel/test-stream2-transform.js
396398
$ make coverage-report-js
397399
```
398400

@@ -401,7 +403,7 @@ by providing the name of a subsystem:
401403

402404
```text
403405
$ make coverage-clean
404-
$ NODE_V8_COVERAGE=coverage/tmp python tools/test.py -J --mode=release child-process
406+
$ NODE_V8_COVERAGE=coverage/tmp tools/test.py -J --mode=release child-process
405407
$ make coverage-report-js
406408
```
407409

0 commit comments

Comments
 (0)