Skip to content

Commit 1370b1a

Browse files
targosruyadorno
authored andcommitted
deps: fix V8 build on Windows with MSVC
PR-URL: #44741 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]> PR-URL: #45230 Reviewed-By: Yagiz Nizipli <[email protected]>
1 parent 3cd6367 commit 1370b1a

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

common.gypi

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636

3737
# Reset this number to 0 on major V8 upgrades.
3838
# Increment by one for each non-official patch applied to deps/v8.
39-
'v8_embedder_string': '-node.3',
39+
'v8_embedder_string': '-node.4',
4040

4141
##### V8 defaults for Node.js #####
4242

deps/v8/src/wasm/function-body-decoder-impl.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -2171,7 +2171,7 @@ class WasmDecoder : public Decoder {
21712171
}
21722172

21732173
// TODO(clemensb): This is only used by the interpreter; move there.
2174-
V8_EXPORT_PRIVATE std::pair<uint32_t, uint32_t> StackEffect(const byte* pc) {
2174+
std::pair<uint32_t, uint32_t> StackEffect(const byte* pc) {
21752175
WasmOpcode opcode = static_cast<WasmOpcode>(*pc);
21762176
// Handle "simple" opcodes with a fixed signature first.
21772177
const FunctionSig* sig = WasmOpcodes::Signature(opcode);

0 commit comments

Comments
 (0)