File tree 1 file changed +6
-3
lines changed
1 file changed +6
-3
lines changed Original file line number Diff line number Diff line change @@ -699,9 +699,12 @@ $ git rev-list upstream/master...HEAD | xargs core-validate-commit
699
699
Optional: When landing your own commits, force push the amended commit to the
700
700
branch you used to open the pull request. If your branch is called ` bugfix ` ,
701
701
then the command would be ` git push --force-with-lease origin master:bugfix ` .
702
- When the pull request is closed, this will cause the pull request to
703
- show the purple merged status rather than the red closed status that is
704
- usually used for pull requests that weren't merged.
702
+ Don't manually close the PR, GitHub will close it automatically later after you
703
+ push it upstream, and will mark it with the purple merged status rather than the
704
+ red closed status. If you close the PR before GitHub adjusts its status, it will
705
+ show up as a 0 commit PR and the changed file history will be empty. Also if you
706
+ push upstream before you push to your branch, GitHub will close the issue with
707
+ red status so the order of operations is important.
705
708
706
709
Time to push it:
707
710
You can’t perform that action at this time.
0 commit comments