Skip to content

Commit 14327ae

Browse files
refacktargos
authored andcommitted
doc: improve instruction to purple merge
PR-URL: #23007 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Denys Otrishko <[email protected]>
1 parent 2888f80 commit 14327ae

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

COLLABORATOR_GUIDE.md

+6-3
Original file line numberDiff line numberDiff line change
@@ -699,9 +699,12 @@ $ git rev-list upstream/master...HEAD | xargs core-validate-commit
699699
Optional: When landing your own commits, force push the amended commit to the
700700
branch you used to open the pull request. If your branch is called `bugfix`,
701701
then the command would be `git push --force-with-lease origin master:bugfix`.
702-
When the pull request is closed, this will cause the pull request to
703-
show the purple merged status rather than the red closed status that is
704-
usually used for pull requests that weren't merged.
702+
Don't manually close the PR, GitHub will close it automatically later after you
703+
push it upstream, and will mark it with the purple merged status rather than the
704+
red closed status. If you close the PR before GitHub adjusts its status, it will
705+
show up as a 0 commit PR and the changed file history will be empty. Also if you
706+
push upstream before you push to your branch, GitHub will close the issue with
707+
red status so the order of operations is important.
705708

706709
Time to push it:
707710

0 commit comments

Comments
 (0)