Skip to content

Commit 14701e5

Browse files
committed
module: runtime deprecate createRequireFromPath()
This commit moves DEP0130 to a runtime deprecation. PR-URL: #27951 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent 3ba6813 commit 14701e5

File tree

3 files changed

+11
-2
lines changed

3 files changed

+11
-2
lines changed

doc/api/deprecations.md

+4-1
Original file line numberDiff line numberDiff line change
@@ -2451,12 +2451,15 @@ instead.
24512451
### DEP0130: Module.createRequireFromPath()
24522452
<!-- YAML
24532453
changes:
2454+
- version: REPLACEME
2455+
pr-url: https://github.com/nodejs/node/pull/27951
2456+
description: Runtime deprecation.
24542457
- version: v12.2.0
24552458
pr-url: https://github.com/nodejs/node/pull/27405
24562459
description: Documentation-only.
24572460
-->
24582461
2459-
Type: Documentation-only
2462+
Type: Runtime
24602463
24612464
Module.createRequireFromPath() is deprecated. Please use [`module.createRequire()`][] instead.
24622465

lib/internal/modules/cjs/loader.js

+6-1
Original file line numberDiff line numberDiff line change
@@ -860,7 +860,12 @@ function createRequireFromPath(filename) {
860860
return makeRequireFunction(m);
861861
}
862862

863-
Module.createRequireFromPath = createRequireFromPath;
863+
Module.createRequireFromPath = deprecate(
864+
createRequireFromPath,
865+
'Module.createRequireFromPath() is deprecated. ' +
866+
'Use Module.createRequire() instead.',
867+
'DEP0130'
868+
);
864869

865870
const createRequireError = 'must be a file URL object, file URL string, or ' +
866871
'absolute path string';

test/message/async_error_sync_esm.out

+1
Original file line numberDiff line numberDiff line change
@@ -5,3 +5,4 @@ Error: test
55
at async three (*fixtures*async-error.js:20:3)
66
at async four (*fixtures*async-error.js:24:3)
77
at async main (*message*async_error_sync_esm.mjs:7:5)
8+
(node:*) [DEP0130] DeprecationWarning: Module.createRequireFromPath() is deprecated. Use Module.createRequire() instead.

0 commit comments

Comments
 (0)