Skip to content

Commit 14bce1e

Browse files
committed
report: do not use uv_default_loop() as fallback
Not seeing an associated `Environment` is a rare condition anyway, but using `uv_default_loop()` as a fallback is not thread-safe. PR-URL: #25652 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
1 parent b113332 commit 14bce1e

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

src/node_report.cc

-2
Original file line numberDiff line numberDiff line change
@@ -307,8 +307,6 @@ static void WriteNodeReport(Isolate* isolate,
307307
writer.json_arraystart("libuv");
308308
if (env != nullptr)
309309
uv_walk(env->event_loop(), WalkHandle, static_cast<void*>(&writer));
310-
else
311-
uv_walk(uv_default_loop(), WalkHandle, static_cast<void*>(&writer));
312310

313311
writer.json_arrayend();
314312

0 commit comments

Comments
 (0)