Skip to content

Commit 150d816

Browse files
committed
deps: V8: cherry-pick bdcda72cd1d8
Original commit message: [platform] Fix compilation on 32-bit Windows Use `extern "C"` to declare the __readfsdword function. Fixes error C2732 in the Node.js CI. Bug: chromium:796644 Change-Id: If261985e65bfdade53ce06ff28afe0e2db402f7a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3086457 Reviewed-by: Clemens Backes <[email protected]> Commit-Queue: Michaël Zasso <[email protected]> Cr-Commit-Position: refs/heads/master@{#76259} Refs: v8/v8@bdcda72 Backport-PR-URL: #40285 PR-URL: #39945 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
1 parent 807b68b commit 150d816

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

common.gypi

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636

3737
# Reset this number to 0 on major V8 upgrades.
3838
# Increment by one for each non-official patch applied to deps/v8.
39-
'v8_embedder_string': '-node.8',
39+
'v8_embedder_string': '-node.9',
4040

4141
##### V8 defaults for Node.js #####
4242

deps/v8/src/base/platform/platform.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@
4747
// And, intrin.h is a very expensive header that we want to avoid here, and
4848
// the cheaper intrin0.h is not available for all build configurations. That is
4949
// why we declare this intrinsic.
50-
unsigned long __readfsdword(unsigned long); // NOLINT(runtime/int)
50+
extern "C" unsigned long __readfsdword(unsigned long); // NOLINT(runtime/int)
5151
#endif // V8_CC_MSVC && V8_HOST_ARCH_IA32
5252
#endif // V8_NO_FAST_TLS
5353

0 commit comments

Comments
 (0)