Skip to content

Commit 1627557

Browse files
committed
src: lock-free init_process_flags
Fix #45152
1 parent 2081082 commit 1627557

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

src/node.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -429,7 +429,7 @@ void ResetSignalHandlers() {
429429
#endif // __POSIX__
430430
}
431431

432-
static std::atomic<uint64_t> init_process_flags = 0;
432+
static std::atomic<uint32_t> init_process_flags = 0;
433433

434434
static void PlatformInit(ProcessInitializationFlags::Flags flags) {
435435
// init_process_flags is accessed in ResetStdio(),

src/node.h

+2-1
Original file line numberDiff line numberDiff line change
@@ -228,7 +228,8 @@ class MultiIsolatePlatform;
228228
class InitializationResultImpl;
229229

230230
namespace ProcessFlags {
231-
enum Flags : uint64_t {
231+
// TODO: Switch to uint32_t to match std::atomic<uint32_t> init_process_flags in node.cc
232+
enum Flags : uint32_t {
232233
kNoFlags = 0,
233234
// Enable stdio inheritance, which is disabled by default.
234235
// This flag is also implied by kNoStdioInitialization.

0 commit comments

Comments
 (0)