Skip to content

Commit 166df9e

Browse files
TrottMylesBorins
authored andcommitted
doc: remove squash guideline from onboarding doc
Although I agree with the guideline people should generally not squash commits in a pull request until the end (in other words, until it's time to land the PR), it is clear from comments and actions in the issue tracker that many do not share that view. This is fine by me, but I do think that we should our documentation should reflect our practices rather than being an aspirational statement. If we *do* wish to preserve this recommendation, it probably belongs in another document anyway as this is not a recommendation for Collaborators only but for anyone opening a pull request. PR-URL: #20413 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent 56c27c6 commit 166df9e

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

doc/onboarding-extras.md

-1
Original file line numberDiff line numberDiff line change
@@ -97,4 +97,3 @@ to update from nodejs/node:
9797
## Best practices
9898

9999
* When making PRs, spend time writing a thorough description.
100-
* Usually only squash at the end of your work.

0 commit comments

Comments
 (0)