Revert "http: align with stream.Writable"

This reverts commit e2f5bb7.

Reverted as it caused a significant performance regression.

See: #37937

PR-URL: #37963
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>

Author: mcollina

lib/_http_client.js

@@ -58,7 +58,7 @@ const Agent = require('_http_agent');
 const { Buffer } = require('buffer');
 const { defaultTriggerAsyncIdScope } = require('internal/async_hooks');
 const { URL, urlToHttpOptions, searchParamsSymbol } = require('internal/url');
-const { kOutHeaders } = require('internal/http');
+const { kOutHeaders, kNeedDrain } = require('internal/http');
 const { connResetException, codes } = require('internal/errors');
 const {
   ERR_HTTP_HEADERS_SENT,
@@ -98,7 +98,7 @@ class HTTPClientAsyncResource {
 }
 
 function ClientRequest(input, options, cb) {
-  FunctionPrototypeCall(OutgoingMessage, this, { autoDestroy: false });
+  FunctionPrototypeCall(OutgoingMessage, this);
 
   if (typeof input === 'string') {
     const urlStr = input;
@@ -304,7 +304,7 @@ function ClientRequest(input, options, cb) {
     if (typeof optsWithoutSignal.createConnection === 'function') {
       const oncreate = once((err, socket) => {
         if (err) {
-          process.nextTick(() => emitError(this, err));
+          process.nextTick(() => this.emit('error', err));
         } else {
           this.onSocket(socket);
         }
@@ -373,8 +373,8 @@ function emitAbortNT(req) {
 
 function ondrain() {
   const msg = this._httpMessage;
-  if (msg && !msg.finished && msg._writableState.needDrain) {
-    msg._writableState.needDrain = false;
+  if (msg && !msg.finished && msg[kNeedDrain]) {
+    msg[kNeedDrain] = false;
     msg.emit('drain');
   }
 }
@@ -400,7 +400,8 @@ function socketCloseListener() {
     if (!res.complete) {
       res.destroy(connResetException('aborted'));
     }
-    emitClose(req);
+    req._closed = true;
+    req.emit('close');
     if (!res.aborted && res.readable) {
       res.push(null);
     }
@@ -410,9 +411,10 @@ function socketCloseListener() {
       // receive a response. The error needs to
       // fire on the request.
       req.socket._hadError = true;
-      emitError(req, connResetException('socket hang up'));
+      req.emit('error', connResetException('socket hang up'));
     }
-    emitClose(req);
+    req._closed = true;
+    req.emit('close');
   }
 
   // Too bad.  That output wasn't getting written.
@@ -436,7 +438,7 @@ function socketErrorListener(err) {
     // For Safety. Some additional errors might fire later on
     // and we need to make sure we don't double-fire the error event.
     req.socket._hadError = true;
-    emitError(req, err);
+    req.emit('error', err);
   }
 
   const parser = socket.parser;
@@ -460,7 +462,7 @@ function socketOnEnd() {
     // If we don't have a response then we know that the socket
     // ended prematurely and we need to emit an error on the request.
     req.socket._hadError = true;
-    emitError(req, connResetException('socket hang up'));
+    req.emit('error', connResetException('socket hang up'));
   }
   if (parser) {
     parser.finish();
@@ -483,7 +485,7 @@ function socketOnData(d) {
     freeParser(parser, req, socket);
     socket.destroy();
     req.socket._hadError = true;
-    emitError(req, ret);
+    req.emit('error', ret);
   } else if (parser.incoming && parser.incoming.upgrade) {
     // Upgrade (if status code 101) or CONNECT
     const bytesParsed = ret;
@@ -515,7 +517,9 @@ function socketOnData(d) {
       socket.readableFlowing = null;
 
       req.emit(eventName, res, socket, bodyHead);
-      emitClose(req);
+      req.destroyed = true;
+      req._closed = true;
+      req.emit('close');
     } else {
       // Requested Upgrade or used CONNECT method, but have no handler.
       socket.destroy();
@@ -700,7 +704,8 @@ function requestOnPrefinish() {
 }
 
 function emitFreeNT(req) {
-  emitClose(req);
+  req._closed = true;
+  req.emit('close');
   if (req.socket) {
     req.socket.emit('free');
   }
@@ -781,10 +786,10 @@ function onSocketNT(req, socket, err) {
         err = connResetException('socket hang up');
       }
       if (err) {
-        emitError(req, err);
+        req.emit('error', err);
       }
       req._closed = true;
-      emitClose(req);
+      req.emit('close');
     }
 
     if (socket) {
@@ -864,23 +869,6 @@ function setSocketTimeout(sock, msecs) {
   }
 }
 
-function emitError(req, err) {
-  req.destroyed = true;
-  req._writableState.errored = err;
-  // Avoid V8 leak, https://github.com/nodejs/node/pull/34103#issuecomment-652002364
-  err.stack; // eslint-disable-line no-unused-expressions
-  req._writableState.errorEmitted = true;
-  req.emit('error', err);
-}
-
-function emitClose(req) {
-  req.destroyed = true;
-  req._closed = true;
-  req._writableState.closed = true;
-  req._writableState.closeEmitted = true;
-  req.emit('close');
-}
-
 ClientRequest.prototype.setNoDelay = function setNoDelay(noDelay) {
   this._deferToConnect('setNoDelay', [noDelay]);
 };