Skip to content

Commit 171ca6b

Browse files
richardlautargos
authored andcommitted
build: don't pass --mode argument to V8 test-runner
V8's test-runner dropped the `--mode` argument some time back, and now produces the following error if run with it: run-tests.py: error: no such option: --mode PR-URL: #39055 Refs: #35705 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
1 parent a440f6c commit 171ca6b

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

Diff for: Makefile

+2-2
Original file line numberDiff line numberDiff line change
@@ -667,12 +667,12 @@ test-v8: v8 ## Runs the V8 test suite on deps/v8.
667667
test-v8-intl: v8
668668
export PATH="$(NO_BIN_OVERRIDE_PATH)" && \
669669
deps/v8/tools/run-tests.py --gn --arch=$(V8_ARCH) \
670-
--mode=$(BUILDTYPE_LOWER) intl \
670+
intl \
671671
$(TAP_V8_INTL)
672672

673673
test-v8-benchmarks: v8
674674
export PATH="$(NO_BIN_OVERRIDE_PATH)" && \
675-
deps/v8/tools/run-tests.py --gn --arch=$(V8_ARCH) --mode=$(BUILDTYPE_LOWER) \
675+
deps/v8/tools/run-tests.py --gn --arch=$(V8_ARCH) \
676676
benchmarks \
677677
$(TAP_V8_BENCHMARKS)
678678

0 commit comments

Comments
 (0)