Skip to content

Commit 1796f03

Browse files
targosbengl
authored andcommitted
build: rename tools workflow and add undici to it
The workflow already updates Corepack, which is a `deps`, not a `tool`. Add subsystem and label variables to the matrix to better control the automated pull requests and add undici to the updated deps. PR-URL: #42246 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Mestery <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tierney Cyren <[email protected]>
1 parent b60262e commit 1796f03

File tree

1 file changed

+23
-5
lines changed

1 file changed

+23
-5
lines changed

.github/workflows/tools.yml

+23-5
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: Tools update
1+
name: Tools and deps update
22
on:
33
schedule:
44
# Run once a week at 00:05 AM UTC on Sunday.
@@ -7,14 +7,16 @@ on:
77
workflow_dispatch:
88

99
jobs:
10-
tools-update:
10+
tools-deps-update:
1111
if: github.repository == 'nodejs/node'
1212
runs-on: ubuntu-latest
1313
strategy:
1414
fail-fast: false # Prevent other jobs from aborting if one fails
1515
matrix:
1616
include:
1717
- id: eslint
18+
subsystem: tools
19+
label: tools
1820
run: |
1921
cd tools
2022
NEW_VERSION=$(npm view eslint dist-tags.latest)
@@ -24,10 +26,14 @@ jobs:
2426
./update-eslint.sh
2527
fi
2628
- id: corepack
29+
subsystem: deps
30+
label: dependencies
2731
run: |
2832
make corepack-update
2933
echo "NEW_VERSION=$(node deps/corepack/dist/corepack.js --version)" >> $GITHUB_ENV
3034
- id: lint-md-dependencies
35+
subsystem: tools
36+
label: tools
3137
run: |
3238
cd tools/lint-md
3339
npm ci
@@ -44,6 +50,8 @@ jobs:
4450
make lint-md-rollup
4551
fi
4652
- id: doc
53+
subsystem: tools
54+
label: tools
4755
run: |
4856
cd tools/doc
4957
npm ci
@@ -57,6 +65,16 @@ jobs:
5765
npm install --ignore-scripts $NEW_VERSION
5866
npm install --ignore-scripts
5967
fi
68+
- id: undici
69+
subsystem: deps
70+
label: dependencies
71+
run: |
72+
NEW_VERSION=$(npm view undici dist-tags.latest)
73+
CURRENT_VERSION=$(node -p "require('./deps/undici/src/package.json').version")
74+
if [ "$NEW_VERSION" != "$CURRENT_VERSION" ]; then
75+
echo "NEW_VERSION=$NEW_VERSION" >> $GITHUB_ENV
76+
./tools/update-undici.sh
77+
fi
6078
steps:
6179
- uses: actions/checkout@v2
6280
with:
@@ -69,6 +87,6 @@ jobs:
6987
author: Node.js GitHub Bot <[email protected]>
7088
body: This is an automated update of ${{ matrix.id }} to ${{ env.NEW_VERSION }}.
7189
branch: actions/tools-update-${{ matrix.id }} # Custom branch *just* for this Action.
72-
commit-message: 'tools: update ${{ matrix.id }} to ${{ env.NEW_VERSION }}'
73-
labels: tools
74-
title: 'tools: update ${{ matrix.id }} to ${{ env.NEW_VERSION }}'
90+
commit-message: '${{ matrix.subsystem }}: update ${{ matrix.id }} to ${{ env.NEW_VERSION }}'
91+
labels: ${{ matrix.label }}
92+
title: '${{ matrix.subsystem }}: update ${{ matrix.id }} to ${{ env.NEW_VERSION }}'

0 commit comments

Comments
 (0)