Skip to content

Commit 184941e

Browse files
danbevevanlucas
authored andcommitted
src: remove TODO about uv errno removal
This commit removes a TODO regarding the removal of uv errno. errno is currently used and cannot be removed so removing the comment to avoid any confusion. PR-URL: #12536 Ref: #4641 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent 4276c21 commit 184941e

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

src/node.cc

-2
Original file line numberDiff line numberDiff line change
@@ -892,8 +892,6 @@ Local<Value> UVException(Isolate* isolate,
892892

893893
Local<Object> e = Exception::Error(js_msg)->ToObject(isolate);
894894

895-
// TODO(piscisaureus) errno should probably go; the user has no way of
896-
// knowing which uv errno value maps to which error.
897895
e->Set(env->errno_string(), Integer::New(isolate, errorno));
898896
e->Set(env->code_string(), js_code);
899897
e->Set(env->syscall_string(), js_syscall);

0 commit comments

Comments
 (0)