Skip to content

Commit 188cff3

Browse files
jasnellMyles Borins
authored and
Myles Borins
committed
deps: update to http-parser 2.5.2
Fixes http-parser regression with IS_HEADER_CHAR check Add test case for obstext characters (> 0x80) is header PR-URL: #5238 Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Myles Borins <[email protected]>
1 parent 8e592bb commit 188cff3

File tree

5 files changed

+22
-4
lines changed

5 files changed

+22
-4
lines changed

deps/http_parser/Makefile

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
# IN THE SOFTWARE.
2020

2121
PLATFORM ?= $(shell sh -c 'uname -s | tr "[A-Z]" "[a-z]"')
22-
SONAME ?= libhttp_parser.so.2.5.1
22+
SONAME ?= libhttp_parser.so.2.5.2
2323

2424
CC?=gcc
2525
AR?=ar

deps/http_parser/http_parser.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -438,7 +438,7 @@ enum http_host_state
438438
* character or %x80-FF
439439
**/
440440
#define IS_HEADER_CHAR(ch) \
441-
(ch == CR || ch == LF || ch == 9 || (ch > 31 && ch != 127))
441+
(ch == CR || ch == LF || ch == 9 || ((unsigned char)ch > 31 && ch != 127))
442442

443443
#define start_state (parser->type == HTTP_REQUEST ? s_start_req : s_start_res)
444444

deps/http_parser/http_parser.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ extern "C" {
2727
/* Also update SONAME in the Makefile whenever you change these. */
2828
#define HTTP_PARSER_VERSION_MAJOR 2
2929
#define HTTP_PARSER_VERSION_MINOR 5
30-
#define HTTP_PARSER_VERSION_PATCH 1
30+
#define HTTP_PARSER_VERSION_PATCH 2
3131

3232
#include <sys/types.h>
3333
#if defined(_WIN32) && !defined(__MINGW32__) && (!defined(_MSC_VER) || _MSC_VER<1600)

deps/http_parser/test.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -3251,7 +3251,7 @@ test_double_content_length_error (int req)
32513251

32523252
parsed = http_parser_execute(&parser, &settings_null, buf, buflen);
32533253
if (parsed != buflen) {
3254-
assert(HTTP_PARSER_ERRNO(&parser) == HPE_MULTIPLE_CONTENT_LENGTH);
3254+
assert(HTTP_PARSER_ERRNO(&parser) == HPE_UNEXPECTED_CONTENT_LENGTH);
32553255
return;
32563256
}
32573257

+18
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
'use strict';
2+
3+
const common = require('../common');
4+
const http = require('http');
5+
const assert = require('assert');
6+
7+
const server = http.createServer(common.mustCall((req, res) => {
8+
res.end('ok');
9+
}));
10+
server.listen(common.PORT, () => {
11+
http.get({
12+
port: common.PORT,
13+
headers: {'Test': 'Düsseldorf'}
14+
}, common.mustCall((res) => {
15+
assert.equal(res.statusCode, 200);
16+
server.close();
17+
}));
18+
});

0 commit comments

Comments
 (0)